[Package Issue]: Rustlang.Rustup is outdated and can't detect version.

[WinkelCode]

Please confirm these before moving forward

• I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
• I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

Rustlang.Rustup is outdated and can't detect version.

Steps to reproduce

Have Rustup installed, then run winget upgrade and check the output.

Note: I un- and re-installed Rustup from the website, behavior is still the same.

Actual behavior

Rustup version isn't detected:

Rustup is now on v1.25.1, WinGet is still on 1.24.4.

Expected behavior

Version is detected and rustup is hopefully up-to-date.

Environment

Windows Package Manager v1.2.11601
Windows: Windows.Desktop v10.0.22000.795
Package: Microsoft.DesktopAppInstaller v1.17.11601.0

Screenshots and Logs

No response

[Trenly]

The reason the version is “Unknown” is because the installer never sets the DisplayVersion key to tell Windows what version of the software is installed. The only way to fix the unknown version is to have the publisher make changes to their build script so that the installer sets the version when installing

[jedieaston]

I just opened a PR to fix the version, at least, although @Trenly is right about your other issue.

[jedieaston]

And I opened a PR to fix the issue on the Rustup side: rust-lang/rustup#3047

[WinkelCode]

The reason the version is “Unknown” is because the installer never sets the DisplayVersion key to tell Windows what version of the software is installed. The only way to fix the unknown version is to have the publisher make changes to their build script so that the installer sets the version when installing

Should software like this even be on WinGet then? Having one of these programs installed makes it redownload the installer every time winget upgrade --all is executed.

Hopefully @jedieaston's PR is merged quickly and solves this case, but I'm wondering why this isn't considered during package approval.

[jedieaston]

There's a mitigation for the infinite upgrade problem in winget 1.3, which should be released shortly into stable: microsoft/winget-cli#1765

(You can also install a release candidate build to get it now: https://github.com/microsoft/winget-cli/releases/tag/v1.3.1872)

[dmad]

I've "solved" the issue for now by manually creating (and updating) the DisplayVersion key:

`
Windows Registry Editor Version 5.00

[HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Rustup]
"DisplayVersion"="1.64.0"
`

[Trenly]

And I opened a PR to fix the issue on the Rustup side: rust-lang/rustup#3047

@msftbot Installer-Issue
@msftbot Area-External

[anarelion]

We should properly format the download URLs like in #95599 , any version upgrade will break the SHA256 and make this package impossible to install.

[fbstj]

rust-lang/rustup#3047 should have fixed this in version 1.25.2 released last week

[jmcscript]

rust-lang/rustup#3047 should have fixed this in version 1.25.2 released last week

I still have the issue on 1.25.2

[gotounix]

@mcdonaldjc rust-lang/rustup#3047 is not in 1.25.2, so it's not fixed in 1.25.2.

[jmcscript]

@gotounix rust-lang/rustup#3047 is not in 1.25.2, so it's not fixed in 1.25.2.

My bad. I must be confused because 1.25.2 was released on 2023-02-01. Yet, that pull request was merged into the master branch on 2022-08-27. What am I missing here? Not trying to be a nuisance.

[khaneliman]

@gotounix rust-lang/rustup#3047 is not in 1.25.2, so it's not fixed in 1.25.2.

My bad. I must be confused because 1.25.2 was released on 2023-02-01. Yet, that pull request was merged into the master branch on 2022-08-27. What am I missing here? Not trying to be a nuisance.

Not sure what their git flow is, but i see it in the upcoming version changelog. https://github.com/rust-lang/rustup/pull/3273/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR49

[jmcscript]

@khaneliman, that's nice, thanks. It looks like it can be merged into the master branch but not go out with their releases. Guess I can look forward to it soon!

[fbstj]

this seems to have been fixed by #103496

[supleed2]

Ran winget install Rustlang.Rustup --force just now which installed v1.26.0 and now winget detects the rustup version correctly, this issue seems to be solved :)