Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: winget cannot find pokemon showdown version and always thinks there is an available upgrade #40529

Closed
ix0rai opened this issue Jan 11, 2022 · 4 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@ix0rai
Copy link

ix0rai commented Jan 11, 2022

Brief description of your issue

When installing pokemon showdown through winget, winget always acts as if there is an applicable update to 0.3.0 for it and claims that the current installed version is Unknown
image

Performing the upgrade does not fix the issue, the version is still Unknown

Steps to reproduce

  1. install winget
  2. install Smogon.PokemonShowdown
  3. run winget upgrade
  4. see that the version is unknown and there's an available upgrade

Expected behavior

the latest version of showdown should have been installed and recognised by winget

Actual behavior

winget does not recognise that showdown is already on the latest version

Environment

Windows Package Manager v1.1.13405
Windows: Windows.Desktop v10.0.19044.1415
Package: Microsoft.DesktopAppInstaller v1.16.13405.0
@ix0rai ix0rai added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jan 11, 2022
@ghost ghost added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 11, 2022
@lychichem
Copy link
Contributor

It is because pokemon showdown doesn't write displayversion registery key, so winget cannot read it from ARP list. You should ask the developer of pokemon showdown to make their installer write this key.

@jedieaston
Copy link
Contributor

This issue was fixed (or at least mitigated) in microsoft/winget-cli#1765, and that should be in the next preview release.

@Trenly
Copy link
Contributor

Trenly commented Jan 19, 2022

Just for reference, here is their nsi script -
They probably want a dynamic version, but it doesn't seem like they push out new builds to the website that often so ¯_(ツ)_/¯
https://github.com/smogon/pokemon-showdown-client/blob/master/desktop/pokemonshowdown.nsi

@ix0rai
Copy link
Author

ix0rai commented Jul 22, 2022

going to close this as it seems to be entirely on showdown's side

@ix0rai ix0rai closed this as completed Jul 22, 2022
@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

5 participants