Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: LAME.LAME version 3.100.1 #194579

Merged
merged 1 commit into from
Dec 3, 2024
Merged

New package: LAME.LAME version 3.100.1 #194579

merged 1 commit into from
Dec 3, 2024

Conversation

fgimian
Copy link
Contributor

@fgimian fgimian commented Nov 27, 2024 •
edited
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Resolves #194580

Important: This is a second attempt at adding the LAME MP3 encoder to winget. My first attempt can be found here which was later rolled back.

As per previous discussion with @denelon on the removal issue with his comment shown below:

I would say this one is a bit of an outlier, but since the official site for Lame recognizes RareWares as a location for compiled binaries, I don't have any problems with having the package, but I do want to make sure that the appropriate waivers are maintained, and the manifest has some kind of information regarding the correct license and the actual publisher.

I have attempted to rectify this concern in this PR but am happy to work with you to make sure it meets all your requirements. 😄

There is no specific publisher name that I can find, the website just refers to the LAME developers, so I used LAME as the publisher name. Hope this is OK.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@fgimian fgimian force-pushed the LAME.LAME-3.100.1-751bd3d6-77cc-4e0b-8d9d-bc3d9e1f1215 branch from 4e1e232 to 017ef7f Compare November 27, 2024 09:54
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@fgimian fgimian changed the title LAME.LAME version 3.100.1 New package: LAME.LAME version 3.100.1 Nov 27, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain Validation-Executable-Error labels Nov 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 27, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

No errors to post.

(Automated response - build 899.)

@fgimian
Copy link
Contributor Author

fgimian commented Dec 2, 2024

@denelon @stephengillie Is there anything further required from my end to push this along?

Thanks heaps
Fotis

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 2, 2024
@denelon
Copy link
Contributor

denelon commented Dec 3, 2024

The domains don't match between the project and the download URL. That will need a waiver if it's a valid URL.

@fgimian
Copy link
Contributor Author

fgimian commented Dec 3, 2024

The domains don't match between the project and the download URL. That will need a waiver if it's a valid URL.

Thanks for the reply. As per our previous discussion at #155441 (comment), the RareWares site is the site that is linked as the download source for binaries from the official LAME site. These are technically compiled by another developer and distributed to the public as the LAME project only provides source code.

If there's anything further I can do to assist with this please let me know. If you still feel this package is simply not suitable for WinGet due to the points mentioned, I am happy to close the PR and avoid raising it again in future.

Kindest Regards
Fotis

@denelon
Copy link
Contributor

denelon commented Dec 3, 2024

@stephengillie the link in the comment above points to the "legwork" to show the InstallerURL is relevant for this package. I'm guessing we'll need a waiver on this one.

@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Executable-Error Validation-Domain Needs-Attention This work item needs to be reviewed by a member of the core team. labels Dec 3, 2024
@stephengillie
Copy link
Collaborator

Verify:
image

@fgimian,

Sorry for all of the difficulties in getting this package merged, in this PR and the previous.

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 036c904 into microsoft:master Dec 3, 2024
2 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 3, 2024
@denelon denelon added this to the 1.10 Packages milestone Dec 3, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@fgimian fgimian deleted the LAME.LAME-3.100.1-751bd3d6-77cc-4e0b-8d9d-bc3d9e1f1215 branch December 3, 2024 22:23
@fgimian
Copy link
Contributor Author

fgimian commented Dec 3, 2024

@stephengillie @denelon Thank you both for your help with this, really appreciate it! 😄

@denelon
Copy link
Contributor

denelon commented Dec 3, 2024

You bet! Glad we could figure it out. Your breadcrumb links were just what we needed. It's hard to remember those "one off" or "few off" situations.

@fgimian
Copy link
Contributor Author

fgimian commented Dec 3, 2024

You bet! Glad we could figure it out. Your breadcrumb links were just what we needed. It's hard to remember those "one off" or "few off" situations.

Completely understand, there's a huge amount of activity in this repo! 😄

Enjoy the rest of your week mate
Fotis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees

@fgimian fgimian

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
1.10 Packages
Development

Successfully merging this pull request may close these issues.

[Package Request]: LAME MP3 Encoder
4 participants
@fgimian @wingetbot @stephengillie @denelon