Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgotten pulls #1675 #1651 #1941

Closed
qiancy98 opened this issue Jun 16, 2020 · 2 comments · Fixed by #1651 or #1675
Closed

Forgotten pulls #1675 #1651 #1941

qiancy98 opened this issue Jun 16, 2020 · 2 comments · Fixed by #1651 or #1675
Milestone

Comments

@qiancy98
Copy link
Contributor

It seems that these two pull requests pass all checks but be forgot by reviewers.
#1651
#1675

@ghost ghost added the Needs: Triage label Jun 16, 2020
@denelon
Copy link
Contributor

denelon commented Jun 18, 2020

It looks like #1651 is blocked, and we just haven't gotten to #1675 yet.

@denelon denelon linked a pull request Jun 18, 2020 that will close this issue
@denelon denelon mentioned this issue Jun 18, 2020
@denelon denelon linked a pull request Jun 18, 2020 that will close this issue
@qiancy98
Copy link
Contributor Author

qiancy98 commented Jun 19, 2020

It looks like #1651 is blocked, and we just haven't gotten to #1675 yet.

Thank you. I ask this because, I traced for a while the merging time of the merged issues, and find almost all "Azure-Pipeline-Passed"-label packages are merged, even they are arised several days later than #1675. I assumed that you ckeck the pr's by creating time or last-active-time, so I raised this problem.

Besides, when searching with the filter "is:pr is:open label:Azure-Pipeline-Passed created:<2020-06-15 ", I find that there are 11 pull requests that pass the pipeline, not blocked by issues, but review required. Some of them only have 3 comments (meaning no reviewer commented it except the bot)!

Thank you for helping my curious of wondering if they are forgetten.

@ghost ghost closed this as completed in #1675 Jun 23, 2020
@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants