Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: OpenStreetMap.Josm should have dependency on "one of" JDK > 17 not only the Oracle one #165368

Closed
2 tasks done
Binnette opened this issue Jul 31, 2024 · 4 comments · Fixed by #166231
Closed
2 tasks done
Labels
Area-Client These issues require changes to the client. Blocking-Issue Manifest validation is blocked by a known issue. In-PR Package-Update This package needs to be updated
Milestone

Comments

@Binnette
Copy link

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

According to winget, Josm required "Oracle.JDK.17 >= 17.0.1.0". But instead it should required one of:

  • Oracle.JDK.17
  • Amazon.Corretto.17.JDK
  • Azul.Zulu.17.JDK
  • EclipseAdoptium.Temurin.17.JDK
  • IBM.Semeru.17.JDK
  • AdoptOpenJDK.OpenJDK.17
  • Microsoft.OpenJDK.17

Instead of forcing the installation of "Oracle.JDK.17", we should set the requirement of one of theses JDK. That way the user can install for example EclipseAdoptium.Temurin.17.JDK and then install OpenStreetMap.Josm

And Josm will work because, Josm can work on any JDK >= 17.0.1.0

Steps to reproduce

  1. winget install EclipseAdoptium.Temurin.17.JDK
  2. winget install OpenStreetMap.Josm

Here winget want to install Oracle.JDK.17, but I already installed another JDK 17

Actual behavior

winget force install Oracle.JDK.17

Expected behavior

winget should check for any JDK 17 and do not force to install Oracle.JDK.17

Environment

Gestionnaire de package Windows v1.8.1911
Copyright (c) Microsoft Corporation. Tous droits réservés.

Windows: Windows.Desktop v10.0.19045.4651
Architecture du système : X64
Package : Microsoft.DesktopAppInstaller v1.23.1911.0

Répertoires Winget
-----------------------------------------------------------------------------------------------------------------------------------------
Journaux                                     %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
Paramètres utilisateurs                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json
Répertoire des liens portables (utilisateur) %LOCALAPPDATA%\Microsoft\WinGet\Links
Répertoire des liens portables (ordinateur)  C:\Program Files\WinGet\Links
Racine de package portable (utilisateur)     %LOCALAPPDATA%\Microsoft\WinGet\Packages
Racine du package portable                   C:\Program Files\WinGet\Packages
Racine de package portable (x86)             C:\Program Files (x86)\WinGet\Packages
Téléchargements du programme d’installation  %USERPROFILE%\Downloads

Liens
---------------------------------------------------------------------------------------------
Déclaration de confidentialité        https://aka.ms/winget-privacy
Contrat de licence                    https://aka.ms/winget-license
Avis de tiers                         https://aka.ms/winget-3rdPartyNotice
Page d’accueil                        https://aka.ms/winget
Conditions générales du Windows Store https://www.microsoft.com/en-us/storedocs/terms-of-sale

Paramètre administrateur                  État
---------------------------------------------------
LocalManifestFiles                        Désactivé
BypassCertificatePinningForMicrosoftStore Désactivé
InstallerHashOverride                     Désactivé
LocalArchiveMalwareScanOverride           Désactivé
ProxyCommandLineOptions                   Désactivé
DefaultProxy                              Désactivé

Screenshots and Logs

No response

@Binnette Binnette added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 31, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jul 31, 2024
@Trenly
Copy link
Contributor

Trenly commented Jul 31, 2024

Unfortunately "one-of" dependencies are not currently supported.

@microsoft-github-policy-service microsoft-github-policy-service bot added Area-Client These issues require changes to the client. Blocking-Issue Manifest validation is blocked by a known issue. Help-Wanted This is a good candidate work item from the community. and removed Needs-Triage This work item needs to be triaged by a member of the core team. Issue-Bug It either shouldn't be doing this or needs an investigation. labels Jul 31, 2024
@Dragon1573
Copy link
Contributor

image

There's no pre-installed JDK or JRE in a brand new Windows Sandbox instance. Seems OpenStreetMap.Josm can handle JDK/JRE on its own?

Only modified:

image

@stephengillie
Copy link
Collaborator

Unfortunately "one-of" dependencies are not currently supported.

Generally for these cases, we omit the dependency. The same should probably be done for this package.

@stephengillie stephengillie added the Package-Update This package needs to be updated label Jul 31, 2024
@Binnette
Copy link
Author

Also, when I install Josm with winget, I saw that it install with its own embed JRE. So this dependency is useless and can be removed.

@microsoft-github-policy-service microsoft-github-policy-service bot added In-PR and removed Help-Wanted This is a good candidate work item from the community. labels Aug 5, 2024
@denelon denelon added this to the 1.10 Packages milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Client These issues require changes to the client. Blocking-Issue Manifest validation is blocked by a known issue. In-PR Package-Update This package needs to be updated
Projects
None yet
5 participants