Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow InstallShield pass validation #1161

Closed
Reset816 opened this issue May 26, 2020 · 6 comments
Closed

Allow InstallShield pass validation #1161

Reset816 opened this issue May 26, 2020 · 6 comments
Labels
Area-Manifest This may require a change to the manifest Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Milestone
1.7 Packages

Comments

@Reset816
Copy link
Contributor

Reset816 commented May 26, 2020 •
edited
Loading

#661 For example, the Adobe Acrobat Reader DC's installer type should be InstallShield.
image
Although if i changed the type to inno in the yaml and the validation run successfully, winget failed the validation of type if the installertype is InstallShield.
image
image
image
@Reset816 Reset816 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 26, 2020
@Reset816 Reset816 changed the title Add InstallShild support Allow InstallShild pass validation May 27, 2020
@oxygen-dioxide
Copy link
Contributor

"InstallShild" should be "InstallShield". However, "InstallShield" failed validation, too.

@Reset816
Copy link
Contributor Author

@oxygen-dioxide oh thank you for catching this, I will correct the mistake right now

@Reset816 Reset816 changed the title Allow InstallShild pass validation Allow InstallShield pass validation May 29, 2020
@Reset816 Reset816 mentioned this issue May 30, 2020
Closed
@denelon
Copy link
Contributor

denelon commented Jan 6, 2021

Is this issue resolved?

@oxygen-dioxide
Copy link
Contributor

Is this issue resolved?

No. Installshield needs config file #246

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jan 14, 2021
@ghost
Copy link

ghost commented Jan 14, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this as completed Jan 21, 2021
@denelon denelon removed Needs: author feedback No-Recent-Activity No activity has occurred on this work item for seven days. labels Feb 3, 2021
@denelon denelon reopened this Feb 3, 2021
@denelon denelon added the Area-Manifest This may require a change to the manifest label May 21, 2021
@denelon denelon added this to the Backlog - Packages milestone May 21, 2021
@OfficialEsco OfficialEsco mentioned this issue Jan 20, 2022
Open
@Trenly
Copy link
Contributor

Trenly commented Feb 24, 2022

@denelon - Since this is duplicated over at CLI, can probably be closed here?

@denelon denelon closed this as completed Feb 24, 2022
@denelon denelon modified the milestones: Backlog-Pipelines, 1.7 Packages Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Manifest This may require a change to the manifest Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Milestone
1.7 Packages
Development

No branches or pull requests
4 participants
@Trenly @Reset816 @oxygen-dioxide @denelon