From d9062eaf27997e00671a4bb36a895e9df2478de0 Mon Sep 17 00:00:00 2001 From: SkandaBT <9980056379Skanda@gmail.com> Date: Sat, 29 Jun 2024 10:39:08 +0530 Subject: [PATCH 01/13] Update README.md --- README.md | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index 33d044433a..a48485b05a 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,3 @@ - # ![WinGet Icon](.github/images/WindowsPackageManager_Assets/ICO/PNG/_40.png) Windows Package Manager ## WinGet Client @@ -13,7 +12,7 @@ If you are new to the Windows Package Manager, you might want to [Explore the Wi ## Installing The Client > [!NOTE] -> The client requires Windows 10 1809 (build 17763) or later at this time. Windows Server 2019 is not supported as the Microsoft Store is not available nor are updated dependencies. It may be possible to install on Windows Server 2022, this should be considered experimental (not supported), and requires dependencies to be manually installed as well. +> The client requires Windows 10 1809 (build 17763) or later at this time. Windows Server 2019 is not supported as the Microsoft Store is not available nor are updated dependencies. It may be possible to install on Windows Server 2022, this should be considered experimental (not supported) and requires dependencies to be manually installed as well. ### Microsoft Store [Recommended] @@ -61,7 +60,7 @@ You can also [build the client yourself](#building-the-client). While the client ## Windows Package Manager Release Roadmap -The plan for delivering next Windows Package Manager releases is described included in our [discussions](https://github.com/microsoft/winget-cli/discussions/2063), and will be updated as the project proceeds. +The plan for delivering the next Windows Package Manager releases is described and included in our [discussions](https://github.com/microsoft/winget-cli/discussions/2063), and will be updated as the project proceeds. ## Overview of the Windows Package Manager @@ -77,19 +76,19 @@ This winget-cli repository includes the source code designed to build the client ### Sources -The client is built around the concept of sources; a set of packages effectively. Sources provide the ability to discover and retrieve the metadata about the packages, so that the client can act on it. +The client is built around the concept of sources; a set of packages effectively. Sources provide the ability to discover and retrieve the metadata about the packages so that the client can act on it. * The default "winget" source includes packages in the [Windows Package Manager Community Repository](https://github.com/microsoft/winget-pkgs). * The default "msstore" source includes packages in the Microsoft Store. -* It is also possible to host your own private [REST based](https://github.com/microsoft/winget-cli-restsource) source. +* It is also possible to host your own private [REST-based](https://github.com/microsoft/winget-cli-restsource) source. ## Building the client 1. Clone the repository 2. Configure your system, please use the [configuration file](.configurations/configuration.dsc.yaml). This can be applied by either: * [Dev Home](https://github.com/microsoft/devhome)'s machine configuration tool - * WinGet configuration. Run `winget configure .configurations/configuration.dsc.yaml` from the project root so relative paths resolve correctly -3. Run `vcpkg integrate install` from Developer Command Prompt for VS 2022. This is one time setup step until configuration file in step 2 is updated to work with vcpkg setup. + * WinGet configuration. Run `winget configure .configurations/configuration.dsc.yaml` from the project root so relative paths resolve correctly. +3. Run `vcpkg integrate install` from the Developer Command Prompt for VS 2022. This is a one time setup step until the configuration file in step 2 is updated to work with vcpkg setup. ### Prerequisites @@ -110,11 +109,11 @@ The client is built around the concept of sources; a set of packages effectively ### Building -Open `winget-cli\src\AppInstallerCLI.sln` in Visual Studio and build. We currently only build using the solution; command line methods of building a VS solution should work as well. After the build finishes, deploy the solution from Build > Deploy Solution. You can then run the client from the command line using `wingetdev`. +Open `winget-cli\src\AppInstallerCLI.sln` in Visual Studio and build. We currently only build using the solution; command-line methods of building a VS solution should work as well. After the build finishes, deploy the solution from Build > Deploy Solution. You can then run the client from the command line using `wingetdev`. ## Credit -We would like to thank [Keivan Beigi (@kayone)](https://github.com/kayone) for his work on AppGet which helped us on the initial project direction for Windows Package Manager. +We would like to thank [Keivan Beigi (@kayone)](https://github.com/kayone) for his work on AppGet which helped us with the initial project direction for Windows Package Manager. ## Contributing @@ -137,11 +136,11 @@ The winget.exe client is instrumented to collect usage and diagnostic (error) da If you build the client yourself the instrumentation will not be enabled and no data will be sent to Microsoft. -The winget.exe client respects machine wide privacy settings and users can opt-out on their device, as documented in the Microsoft Windows privacy statement [here](https://support.microsoft.com/help/4468236/diagnostics-feedback-and-privacy-in-windows-10-microsoft-privacy). In addition, you may also explicitly block telemetry using [settings](https://docs.microsoft.com/windows/package-manager/winget/settings) +The winget.exe client respects machine-wide privacy settings and users can opt-out on their device, as documented in the Microsoft Windows privacy statement [here](https://support.microsoft.com/help/4468236/diagnostics-feedback-and-privacy-in-windows-10-microsoft-privacy). In addition, you may also explicitly block telemetry using [settings](https://docs.microsoft.com/windows/package-manager/winget/settings) -In short to opt-out, do one of the following: +In short, to opt-out, do one of the following: -**Windows 11**: Go to `Start`, then select `Settings` > `Privacy & security` > `Diagnostics & feedback` > `Diagnostic data` and unselect `Send optional diagnostic data`. +**Windows 11**: Go to `Start`, then select `Settings` > `Privacy & Security` > `Diagnostics & feedback` > `Diagnostic data` and unselect `Send optional diagnostic data`. **Windows 10**: Go to `Start`, then select `Settings` > `Privacy` > `Diagnostics & feedback`, and select `Required diagnostic data`. From 82ba841ade53cdd4084719ce113ea5b85f0442ab Mon Sep 17 00:00:00 2001 From: SkandaBT <9980056379Skanda@gmail.com> Date: Sat, 29 Jun 2024 10:43:00 +0530 Subject: [PATCH 02/13] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 6181f2b356..41637090ad 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ - + - [ ] I have signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs). - [ ] This pull request is related to an issue. From 51a387057067dad4ff79576e4acf9698c93d02d8 Mon Sep 17 00:00:00 2001 From: SkandaBT <9980056379Skanda@gmail.com> Date: Sat, 29 Jun 2024 10:43:39 +0530 Subject: [PATCH 03/13] Update Bug_Report.yml --- .github/ISSUE_TEMPLATE/Bug_Report.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/Bug_Report.yml b/.github/ISSUE_TEMPLATE/Bug_Report.yml index 06f87dbdb5..cbb4b5b49b 100644 --- a/.github/ISSUE_TEMPLATE/Bug_Report.yml +++ b/.github/ISSUE_TEMPLATE/Bug_Report.yml @@ -4,7 +4,7 @@ body: - type: markdown attributes: value: | - > This bug tracker is monitored by Windows Package Manager development team and other technical folks. + > This bug tracker is monitored by the Windows Package Manager development team and other technical folks. > > **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to GitHub issues**. > Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. From 3e802cd715c56d640a801c7e30b3706f285a6458 Mon Sep 17 00:00:00 2001 From: SkandaBT <9980056379Skanda@gmail.com> Date: Sat, 29 Jun 2024 10:44:12 +0530 Subject: [PATCH 04/13] Update Documentation_Issue.yml --- .github/ISSUE_TEMPLATE/Documentation_Issue.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/Documentation_Issue.yml b/.github/ISSUE_TEMPLATE/Documentation_Issue.yml index 4288302f0d..56960be27a 100644 --- a/.github/ISSUE_TEMPLATE/Documentation_Issue.yml +++ b/.github/ISSUE_TEMPLATE/Documentation_Issue.yml @@ -5,6 +5,6 @@ body: - type: textarea attributes: label: Brief description of your issue - placeholder: Briefly describe which document needs to be corrected and why + placeholder: Briefly describe which document needs to be corrected and why. validations: required: true From 27017b381bfc0a71f31af4732a32d75ff0fb2265 Mon Sep 17 00:00:00 2001 From: SkandaBT <9980056379Skanda@gmail.com> Date: Sat, 29 Jun 2024 10:44:40 +0530 Subject: [PATCH 05/13] Update Feature_Request.yml --- .github/ISSUE_TEMPLATE/Feature_Request.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/Feature_Request.yml b/.github/ISSUE_TEMPLATE/Feature_Request.yml index f5253709c5..6f35f35da7 100644 --- a/.github/ISSUE_TEMPLATE/Feature_Request.yml +++ b/.github/ISSUE_TEMPLATE/Feature_Request.yml @@ -4,7 +4,7 @@ labels: ['Issue-Feature'] body: - type: textarea attributes: - label: Description of the new feature / enhancement + label: Description of the new feature/enhancement placeholder: | A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). @@ -13,6 +13,6 @@ body: - type: textarea attributes: label: Proposed technical implementation details - placeholder: A clear and concise description of what you want to happen + placeholder: A clear and concise description of what you want to happen. validations: required: false From ec1b3977ffcb693b5578c2e96ced4ad64672ca9a Mon Sep 17 00:00:00 2001 From: SkandaBT <9980056379Skanda@gmail.com> Date: Sat, 29 Jun 2024 10:45:18 +0530 Subject: [PATCH 06/13] Update config.yml --- .github/ISSUE_TEMPLATE/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index c3c7944be8..2936342f29 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -8,4 +8,4 @@ contact_links: about: Have a question on something? Start a new discussion thread. - name: Review open issues url: https://github.com/microsoft/winget-cli/issues - about: Please check if your issue or a similar issue has already been submitted + about: Please check if your issue or a similar issue has already been submitted. From 5a5a93751686a6de170a90dab5c8d1c4d8509adc Mon Sep 17 00:00:00 2001 From: SkandaBT <9980056379Skanda@gmail.com> Date: Sat, 29 Jun 2024 11:10:32 +0530 Subject: [PATCH 07/13] Update README.md Co-authored-by: Kaleb Luedtke --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a48485b05a..0d4dc0c450 100644 --- a/README.md +++ b/README.md @@ -60,7 +60,7 @@ You can also [build the client yourself](#building-the-client). While the client ## Windows Package Manager Release Roadmap -The plan for delivering the next Windows Package Manager releases is described and included in our [discussions](https://github.com/microsoft/winget-cli/discussions/2063), and will be updated as the project proceeds. +The plan for delivering the next Windows Package Manager release is described and included in our [discussions](https://github.com/microsoft/winget-cli/discussions/2063), and will be updated as the project proceeds. ## Overview of the Windows Package Manager From 521ea6c6cc5e6def6ae6d9cd3ec74bd087115b0e Mon Sep 17 00:00:00 2001 From: SkandaBT <9980056379Skanda@gmail.com> Date: Sat, 29 Jun 2024 11:11:21 +0530 Subject: [PATCH 08/13] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 41637090ad..6181f2b356 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ - + - [ ] I have signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs). - [ ] This pull request is related to an issue. From d3b65fded117e6ace04556a21a98700cadfc180b Mon Sep 17 00:00:00 2001 From: SkandaBT <9980056379Skanda@gmail.com> Date: Sat, 29 Jun 2024 11:11:50 +0530 Subject: [PATCH 09/13] Update Feature_Request.yml --- .github/ISSUE_TEMPLATE/Feature_Request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/Feature_Request.yml b/.github/ISSUE_TEMPLATE/Feature_Request.yml index 6f35f35da7..a6b67096e2 100644 --- a/.github/ISSUE_TEMPLATE/Feature_Request.yml +++ b/.github/ISSUE_TEMPLATE/Feature_Request.yml @@ -4,7 +4,7 @@ labels: ['Issue-Feature'] body: - type: textarea attributes: - label: Description of the new feature/enhancement + label: Description of the new feature / enhancement placeholder: | A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). From 502abc69f66cb42a40d13ae627d07faf4be0a16e Mon Sep 17 00:00:00 2001 From: snyk-bot Date: Sat, 29 Jun 2024 12:16:06 +0000 Subject: [PATCH 10/13] fix: src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DOTNET-SYSTEMDATASQLCLIENT-6149433 --- src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj b/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj index 7a724c4a23..d24ac46e0d 100644 --- a/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj +++ b/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj @@ -21,7 +21,7 @@ - + From c40bbbdcce7249907f8109ff207abb709bd1e3be Mon Sep 17 00:00:00 2001 From: SkandaBT <9980056379Skanda@gmail.com> Date: Sat, 29 Jun 2024 17:48:14 +0530 Subject: [PATCH 11/13] Revert "[Snyk] Security upgrade Microsoft.PowerShell.SDK from 7.2.8 to 7.2.18" --- src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj b/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj index d24ac46e0d..7a724c4a23 100644 --- a/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj +++ b/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj @@ -21,7 +21,7 @@ - + From 4929724bd28a42d4c9a13c975f50f671bafdbeba Mon Sep 17 00:00:00 2001 From: snyk-bot Date: Sat, 29 Jun 2024 12:18:32 +0000 Subject: [PATCH 12/13] fix: src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DOTNET-SYSTEMDATASQLCLIENT-6149433 --- src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj b/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj index 7a724c4a23..d24ac46e0d 100644 --- a/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj +++ b/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj @@ -21,7 +21,7 @@ - + From 0191cbe49f2cc5d817edd9cf097598ceedea74a7 Mon Sep 17 00:00:00 2001 From: SkandaBT <9980056379Skanda@gmail.com> Date: Sat, 29 Jun 2024 17:55:24 +0530 Subject: [PATCH 13/13] Revert "[Snyk] Security upgrade Microsoft.PowerShell.SDK from 7.2.8 to 7.2.18" --- src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj b/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj index d24ac46e0d..7a724c4a23 100644 --- a/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj +++ b/src/AppInstallerCLIE2ETests/AppInstallerCLIE2ETests.csproj @@ -21,7 +21,7 @@ - +