Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pinning] - Usage of --id should bypass installed package check #3141

Closed
Trenly opened this issue Apr 10, 2023 · 3 comments
Closed

[Pinning] - Usage of --id should bypass installed package check #3141

Trenly opened this issue Apr 10, 2023 · 3 comments
Labels
Command-Pin Issue related to WinGet Pin Experimental This experimental feature can be enabled in settings Issue-Feature This is a feature request for the Windows Package Manager client.
Milestone

Comments

@Trenly
Copy link
Contributor

Trenly commented Apr 10, 2023

Description of the new feature / enhancement

The current implementation of pinning checks to try and map to an installed package before adding the pin. Since the pin only requires the package ID and source list, when --id is provided, there should be no need to attempt the mapping. The given ID can be added to the pinning database directly.

This will help when there are side-by-side installs or matching issues which may prevent pinning due to multiple packages found.

Proposed technical implementation details

This behavior probably should not be default, but enabled through settings.

"pinning" : {
    "directIdAddition" : true
}
@Trenly Trenly added the Issue-Feature This is a feature request for the Windows Package Manager client. label Apr 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Apr 10, 2023
@denelon denelon added Command-Pin Issue related to WinGet Pin and removed Needs-Triage Issue need to be triaged labels Apr 10, 2023
@denelon denelon added this to the v1.5-Client milestone Apr 18, 2023
@florelis
Copy link
Member

@Trenly Do you think this would still be needed after #3167?

@Trenly
Copy link
Contributor Author

Trenly commented Apr 21, 2023

@Trenly Do you think this would still be needed after #3167?

Yes, because #3167 still fails when trying to pin Microsoft.Teams due to multiple strong matches when the Teams Machine Wide Installer is present

@denelon denelon added the Experimental This experimental feature can be enabled in settings label May 1, 2023
@florelis
Copy link
Member

I ended up including this in #3167, so I'm closing the issue. Feel free to re-open if I missed anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Command-Pin Issue related to WinGet Pin Experimental This experimental feature can be enabled in settings Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

No branches or pull requests

3 participants