Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0 Schema "Supports" Zip installer type #2532

Closed
Trenly opened this issue Sep 19, 2022 · 0 comments · Fixed by #2996
Closed

1.2.0 Schema "Supports" Zip installer type #2532

Trenly opened this issue Sep 19, 2022 · 0 comments · Fixed by #2996
Labels
In-PR Issue related to a PR Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@Trenly
Copy link
Contributor

Trenly commented Sep 19, 2022

Brief description of your issue

The 1.2.0 schemas list Zip as an allowable installer type, despite not having NestedInstallerType or NestedInstallerFiles

Steps to reproduce

"InstallerType": {
"type": [ "string", "null" ],
"enum": [
"msix",
"msi",
"appx",
"exe",
"zip",
"inno",
"nullsoft",
"wix",
"burn",
"pwa",
"portable"
],
"description": "Enumeration of supported installer types. InstallerType is required in either root level or individual Installer level"
},

"InstallerType": {
"type": [ "string", "null" ],
"enum": [
"msix",
"msi",
"appx",
"exe",
"zip",
"inno",
"nullsoft",
"wix",
"burn",
"pwa",
"portable"
],
"description": "Enumeration of supported installer types. InstallerType is required in either root level or individual Installer level"
},

Expected behavior

Zip not to be present if it isn't supported

Actual behavior

Zip is present

Proposed Solution

Remove those lines from the schema

@ghost ghost added the Needs-Triage Issue need to be triaged label Sep 19, 2022
@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Sep 21, 2022
@denelon denelon added this to WinGet Feb 14, 2023
@denelon denelon added this to the v1.5-Client milestone Feb 14, 2023
@Trenly Trenly mentioned this issue Feb 22, 2023
2 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR Issue related to a PR label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to Done in WinGet Feb 23, 2023
@denelon denelon removed this from WinGet Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In-PR Issue related to a PR Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants