Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winget always tries to update packages that are already up to date #2111

Closed
Un1q32 opened this issue Apr 20, 2022 · 10 comments
Closed

winget always tries to update packages that are already up to date #2111

Un1q32 opened this issue Apr 20, 2022 · 10 comments
Labels
Area-External Issue outside of winget-cli source Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@Un1q32
Copy link

Un1q32 commented Apr 20, 2022

Brief description of your issue

Every time I run winget upgrade --all it tries to update VLC, it finishes and says it's successful, and opening VLC confirms that it was successful in updating, but it keeps updating every time I run winget upgrade --all, even though it's already up to date. The same issue has happened with other packages.

Steps to reproduce

Wait for an installed package to get an update
Run winget upgrade --all
It updates the package
Check that package is updated (it should be)
Run winget upgrade --all again
It will attempt to update the package again

Expected behavior

winget upgrade --all should report that there are no updates when all packages are up to date.

Actual behavior

winget upgrade --all attempts to update packages that it has previously updated even though they are already up to date.

Environment

Windows Package Manager v1.2.10271
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.613
Package: Microsoft.DesktopAppInstaller v1.17.10271.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale
@ghost ghost added the Needs-Triage Issue need to be triaged label Apr 20, 2022
@denelon
Copy link
Contributor

denelon commented Apr 20, 2022

https://code.videolan.org/videolan/vlc/-/issues/26850

@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-External Issue outside of winget-cli source and removed Needs-Triage Issue need to be triaged labels Apr 20, 2022
@Un1q32
Copy link
Author

Un1q32 commented Apr 20, 2022

@denelon I guess this is an issue with vlc then, but I've had the same issue with updating visual c++ with winget. Is that caused by the same issue?

@denelon
Copy link
Contributor

denelon commented Apr 20, 2022

@denelon denelon added this to the v1.3-Client milestone Apr 20, 2022
@cloudrootab
Copy link

Several installations don't adjust/set DisplayVersion in the registry. Leading to winget downloading and installing said programs upon every update.
Looking through the open issues in the v1.3 milestone roadmap, suggests that there are efforts being made to hopefully solve this. I'm hoping that reporting/setting the correct version will be mandatory, and not an optional thing. And if the installer doesn't set the correct version, maybe winget should?

I'm sure the devs have a long-term and good plan being worked on. That will solve this annoyances in the long term.

@cjwijtmans
Copy link

cjwijtmans commented May 12, 2022

imho maybe there could be a winget feature that makes sure the version is correctly updated when the installer succeeds. Which could also be a step forward to support archive files instead of installers only.

@denelon denelon modified the milestones: v1.3-Client, v1.4-Client May 31, 2022
@cjwijtmans
Copy link

The question is should winget fail an install when the installer failed to update the version. Which leaves the machine with an installed software that is incorrect somehow. Which could be fixed by sandboxing the installation first and if its correct then write the files from the sandbox on the system. Which is how some package managers work on linux. OR should winget correct the version string after a succesful install if the installer failed to do it? Which still doesnt gaurentee that the installed software was correct.

@denelon
Copy link
Contributor

denelon commented Jun 13, 2022

There are a couple of features in the works to start addressing this. One is verifying what happens in an upgrade scenario. I've seen reports where during upgrade, the version isn't properly modified. It's likely we would depend on the Independent Software Vendor (ISV) / publisher to correct the installer behavior.

@cloudrootab
Copy link

There are a couple of features in the works to start addressing this. One is verifying what happens in an upgrade scenario. I've seen reports where during upgrade, the version isn't properly modified. It's likely we would depend on the Independent Software Vendor (ISV) / publisher to correct the installer behavior.

Food for thought. If the ISV's did their part correctly. Then this wouldn't be an issue to begin with. So I'm hoping for some sort of failsafe for the plethora of installers that don't update the versions correctly in the long term.
Two cents deposited. And I'm sure/hopeful that the aforementioned "features in the works", will be the best solution to a fairly annoying issue.

Thanks!

@denelon denelon modified the milestones: v1.4-Client, v1.5-Client Dec 28, 2022
@denelon denelon modified the milestones: v1.5-Client, v.Next-Client Apr 18, 2023
@kvxrun
Copy link

kvxrun commented Dec 8, 2023

this is happening to me even though v3.0.20 is installed but winget says I have v3.0.19 installed.

@Un1q32
Copy link
Author

Un1q32 commented Dec 8, 2023

I only vaugely remember making this issue, but I think it was an issue with VLC, and the solution was to uninstall and reinstall VLC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-External Issue outside of winget-cli source Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

5 participants