Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messaging for unavailable source/cache #2058

Open
denelon opened this issue Mar 31, 2022 · 2 comments
Open

Improve error messaging for unavailable source/cache #2058

denelon opened this issue Mar 31, 2022 · 2 comments
Labels
Area-Output Issue related to CLI output Issue-Feature This is a feature request for the Windows Package Manager client.

Comments

@denelon
Copy link
Contributor

denelon commented Mar 31, 2022

Experiencing this issue now. Found the root cause to be that https://winget.azureedge.net/cache/source.msix is returning a 404 error. A 404 error should be communicated to the user in a more direct way than a generic "data is missing" message.

Edit - additional info:

Windows Package Manager v1.1.13405
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.348
Package: Microsoft.DesktopAppInstaller v1.16.13405.0

Edit 2 - https://winget.azureedge.net/cache/source.msix is no longer returning a 404 error, and winget functionality is restored on my system. Probably a temporary issue server-side. Should still be better communicated to the end user.

Originally posted by @NPittinger in #1348 (comment)

@ghost ghost added the Needs-Triage Issue need to be triaged label Mar 31, 2022
@denelon denelon added Issue-Feature This is a feature request for the Windows Package Manager client. and removed Needs-Triage Issue need to be triaged labels Mar 31, 2022
@denelon denelon added this to the v.Next-Client milestone Mar 31, 2022
@jpluimers
Copy link

In addition to the error message, also consider the logging as I had a really hard time out finding the information to solve Need help trying to figure out what domains/IPs to whitelist for installing packages · Discussion #2304 · microsoft/winget-cli.

Basically both the error message 0x8a15000f : Data required by the source is missing and the logging WindowsPackageManager.dll!00007FF92ED457C2: ReturnHr(1) tid(1734) 80072EFD Msg:[winrt::hresult_error: Kan geen verbinding met de server maken.] are very unhelpful as they do not indicate what they are trying to download.

So please at least:

  1. add a reference to https://winget.azureedge.net/cache/source.msix in both the error message and the logging
  2. ensure that the logging also contains 0x8a15000f : Data required by the source is missing (currently this is only in the error message but not in the logging so it is hard to correlate what happens when in the logging with the error message).

Thanks!

@Trenly
Copy link
Contributor

Trenly commented Jun 16, 2023

[Policy] Area-Output

@microsoft-github-policy-service microsoft-github-policy-service bot added the Area-Output Issue related to CLI output label Jun 16, 2023
@denelon denelon removed this from the v.Next-Client milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Output Issue related to CLI output Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

No branches or pull requests

3 participants