Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork software need to re-setup everything a new install is made #1747

Closed
xarthurx opened this issue Nov 28, 2021 · 6 comments
Closed

Fork software need to re-setup everything a new install is made #1747

xarthurx opened this issue Nov 28, 2021 · 6 comments
Milestone

Comments

@xarthurx
Copy link

Brief description of your issue

When installing the software "Fork" (a git client) through winget, everything there's a new version released and installed, user settings will be overwritten and I need to setup everything again.

Steps to reproduce

  1. Install Fork
  2. Setup fork
  3. Wait for a new version release
  4. Install the new version

Expected behavior

The newly installed version should inherit the original user settings.

Actual behavior

user settings are overwritten and not respected.

Environment

Windows Package Manager v1.1.12986
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.318
Package: Microsoft.DesktopAppInstaller v1.16.12986.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale
@ghost ghost added the Needs-Triage Issue need to be triaged label Nov 28, 2021
@xarthurx
Copy link
Author

The settings should exist in ~\AppData\Local\Fork

@jedieaston
Copy link
Contributor

jedieaston commented Nov 28, 2021

This looks (although I'm not 100% certain) to be a bug with Fork's installer (or intentional behavior, since if you're re-running the installer it may be that your local install is borked).

I'd suggest reaching out to them and asking them to add an argument to their installer that disables this behavior (/upgrade, perhaps?). Maybe there already is such an option and it just isn't documented, I tried to get their installer to list the options and it wouldn't.

edit: nvm, they're using Squirrel, which doesn't expose such a thing (Squirrel/Squirrel.Windows#1089). This should be a feature request for winget (maybe a separate issue) where if winget is upgrading a Squirrel-installed application (which a lot of apps including Teams and Discord are), it will invoke the Update.exe executable in the application's installation directory which supports silent upgrades instead of trying to run a newer version of the installer.

@xarthurx
Copy link
Author

Would you do this (feature request)?
I don't 100% understand the specific feature to request.

Thank you.

@jedieaston
Copy link
Contributor

Done :)

#1748.

@denelon denelon removed the Needs-Triage Issue need to be triaged label Nov 29, 2021
@denelon
Copy link
Contributor

denelon commented Nov 29, 2021

@xarthurx,

I've linked a couple of related issues to #1748. I'm going to go ahead and close this issue since we've captured the work in other feature requests.

@denelon denelon closed this as completed Nov 29, 2021
@denelon denelon added this to the v1.3-Client milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@xarthurx @jedieaston @denelon and others