Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rust-condition-script-cargo_make_current_task_initial_makefile_directory-substitution plugin with new cargo make feature #171

Closed
wmmc88 opened this issue May 30, 2024 · 3 comments · Fixed by #208
Assignees

Comments

@wmmc88
Copy link
Collaborator

wmmc88 commented May 30, 2024

          With resolution of https://github.com/sagiegurari/cargo-make/issues/1081, this plugin may be no longer needed. This can be addressed in a followup

Originally posted by @wmmc88 in #143 (comment)

@svasista-ms
Copy link
Contributor

@wmmc88, I'm working on this issue. I'll raise a PR after #186 is merged.

@wmmc88 wmmc88 assigned svasista-ms and unassigned wmmc88 Aug 8, 2024
@wmmc88
Copy link
Collaborator Author

wmmc88 commented Aug 15, 2024

@svasista-ms On closer inspection, I believe this task is blocked by sagiegurari/cargo-make#1132 merging. While sagiegurari/cargo-make#1081 was resolved, it still fails to expand the args based of local testing. sagiegurari/cargo-make#1132 should fix that.

@wmmc88
Copy link
Collaborator Author

wmmc88 commented Aug 30, 2024

@svasista-ms you should be unblocked now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants