QA: update code for golangci-lint and run go fmt.
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugins/nat/nat_windows.go
Outdated
| nm network.Manager | ||
| } | ||
|
|
||
| type netPlugin struct { |
There was a problem hiding this comment.
This is shifted right which is not correct.
There was a problem hiding this comment.
That's actually go fmt identifying code snippets within the comment and attempting to indent it so it can get formatted as code by godoc.
Either way, I've noticed that these comments, initially added in this PR, are most likely redundant since the netPlugin struct has been moved into its own package, so I'll be removing them completely.
aznashwan
force-pushed
the
linter-fixes
branch
2 times, most recently
from
5877c01 to
526ea4a
Compare
princepereira
approved these changes
Sep 13, 2023
Signed-off-by: Nashwan Azhari <[email protected]>
Signed-off-by: Nashwan Azhari <[email protected]>
aznashwan
force-pushed
the
linter-fixes
branch
from
526ea4a to
9e3c86b
Compare
mdebjit
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the vast majority of the changes are trivial, I'd like to draw the reviewers' attention to the following places where semantics may have slightly changed and I request you take a closer look at:
strings.EqualFold()which has the potential to do something weird on non EN-US systems, but considering it's only used during testing and only seems to be called during tests so it should be a real-world issue.plugin_testing.RunAll()since both the sub-calls toplugin_testing.{RunUnitTest,RunBasicConnectivityTest}in turn already callSetup()/Teardown().