Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

untyped_event and typed_event do not work for events that don't derive from EventHandler or TypedEventHandler (eg Windows.UI.Xaml.Data.CurrentChangingEventHandler) #354

Open
citelao opened this issue Aug 31, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@citelao
Copy link
Contributor

citelao commented Aug 31, 2023

untyped_event and typed_event require events that derive from EventHandler or TypedEventHandler respectively. However, there are a fair number of events that do not derive from these classes. For example, PropertyChanged INotifyPropertyChanged (which, admittedly, can be implemented via other WIL helpers) and Windows.UI.Xaml.Data.CurrentChangingEventHandler.

We should support wil::custom_event for events that use custom handlers/delegates.

@dunhor
Copy link
Member

dunhor commented Sep 19, 2023

This is fixed now, right?

@dunhor dunhor added the bug Something isn't working label Sep 19, 2023
@citelao
Copy link
Contributor Author

citelao commented Sep 26, 2023

No, I didn't fix this with #352.

We still need to introduce something like wil::custom_event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants