Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Whisper ] Elements are still clickable when processor config download fails #70

Open
NingW101 opened this issue Jan 21, 2025 · 3 comments

Comments

@NingW101
Copy link
Contributor

The elements (Upload, Record, Realtime speech) should keep disabled until all initialization work finishes, but I found that the elements remove the disabled attribute and become clickable when processor_config fails to download.

Image
Image

@NingW101
Copy link
Contributor Author

I submitted PR to fix it. PTAL. Thanks.
@ibelem @Honry

@ibelem
Copy link
Contributor

ibelem commented Jan 22, 2025

[1] https://microsoft.github.io/models/microsoft/whisper-base-webnn/resolve/main/processer/preprocessor_config.json
[2] https://huggingface.co/microsoft/whisper-base-webnn/resolve/main/processer/resolve/main/preprocessor_config.json

Thanks @NingW101. In the original design, it will access second URL if the first one fails (the first try was for local deployment scenario), so the first 404 should be OK, and we can get HTTP 200 for the second preprocessor_config.json. Do you mean you cannot download preprocessor_config.json anyway?

@NingW101
Copy link
Contributor Author

In the original design, it will access second URL if the first one fails (the first try was for local deployment scenario), so the first 404 should be OK, and we can get HTTP 200 for the second preprocessor_config.json.

Exactly. It will try to fetch the second configuration json file from huggingface and everything goes well if the network is good.
I encountered this issue because of my local network and found that the elements were clickable even the bug occurred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants