Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port api changes from 5.0 into 3.1 dotnet/sdk #2443

Closed
nohwnd opened this issue May 21, 2020 · 4 comments
Closed

Port api changes from 5.0 into 3.1 dotnet/sdk #2443

nohwnd opened this issue May 21, 2020 · 4 comments
Assignees
Labels

Comments

@nohwnd
Copy link
Member

nohwnd commented May 21, 2020

/fyi @NightOwl888

@nohwnd nohwnd added this to the 16.7.0 milestone May 21, 2020
@nohwnd
Copy link
Member Author

nohwnd commented May 21, 2020

Putting this into 16.7.0, but will address this probably in 16.8.0, I just don't want to forget.

@nohwnd nohwnd modified the milestones: 16.7.0, 16.8.0 Jun 16, 2020
@Sanan07 Sanan07 assigned Sanan07 and unassigned nohwnd Jul 3, 2020
@nohwnd
Copy link
Member Author

nohwnd commented Jul 3, 2020

looked at it earlier this morningn and we probably need to wait till 3.1.5xx branch is snapped.

@Sanan07 did you decide to tackle this one yourself? Because our last agreement was that I will do it, while you watch.

@Sanan07
Copy link
Contributor

Sanan07 commented Jul 3, 2020

@nohwnd Sorry, you are right, I miss-read our conversation.

@Sanan07 Sanan07 assigned nohwnd and unassigned Sanan07 Jul 3, 2020
@nohwnd
Copy link
Member Author

nohwnd commented Aug 21, 2020

Skipping this, we are almost shipping 5.0 now. And 5.0 SDK can be used to build projects that target netcoreapp2.1, so there is no need to not use it.

@nohwnd nohwnd closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants