VSTest is printing using Console.WriteLine instead of using the logger

[krwq]

Description

VSTest should be using logger instead of Console.WriteLine. I.e.:

vstest/src/Microsoft.TestPlatform.Build/Tasks/VSTestTask.cs

Line 132 in e6c198c

Console.WriteLine(Resources.TestRunningSummary, this.TestFileFullPath, this.VSTestFramework);

vstest/src/Microsoft.TestPlatform.Build/Tasks/VSTestTask.cs

Line 301 in e6c198c

Console.WriteLine(Resources.UpdateTestSdkForCollectingCodeCoverage);

This is causing that in some cases output gets lost.

Steps to reproduce

• Clone https://github.com/dotnet/iot/
• Replace following ("Test") task https://github.com/dotnet/iot/blob/a5a53b5a3a287638df0176c483fcb1f3b2fef7f0/build.proj#L59 with

  <Target Name="Test">
    <ItemGroup>
      <UnitTestProjects Include="$(MSBuildThisFileDirectory)src\devices\**\*.Tests.csproj" />
    </ItemGroup>
    <MSBuild Projects="@(UnitTestProjects)" Targets="VSTest"
        ContinueOnError="ErrorAndContinue" />
    <Error Condition="$(MSBuildLastTaskResult) != 'true'"
        Text="Unit tests failed. Please check the detailed log to find out which ones failed." />
  </Target>

Replacing will not be needed once linked PR is merged

• Run build.cmd/build.sh (in the root directory)

If any property is passed to MSBuild task then output gets printed (because of luck it gets run on master node where Console.WriteLine works correctly)

Expected behavior

Test output is displayed

Actual behavior

Build fails but no errors get printed

[ericstj]

It also looks like this task creates a process but doesn't redirect output, so that will further be lost logging.

vstest/src/Microsoft.TestPlatform.Build/Tasks/VSTestForwardingApp.cs

Lines 30 to 51 in e6c198c

	public int Execute()
	{
	var processInfo = new ProcessStartInfo
	{
	FileName = hostExe,
	Arguments = string.Join(" ", this.allArgs),
	UseShellExecute = false,
	};
	Tracing.Trace("VSTest: Starting vstest.console...");
	Tracing.Trace("VSTest: Arguments: " + processInfo.FileName + " " + processInfo.Arguments);
	using (var activeProcess = new Process { StartInfo = processInfo })
	{
	activeProcess.Start();
	this.activeProcessId = activeProcess.Id;
	activeProcess.WaitForExit();
	Tracing.Trace("VSTest: Exit code: " + activeProcess.ExitCode);
	return activeProcess.ExitCode;
	}
	}

[ViktorHofer]

cc @nohwnd

[nohwnd]

@ViktorHofer did you see this issue happen somewher or why are you tagging me just now?:)

[ViktorHofer]

@akoeplinger a colleague of mine is hitting this issue in mono/linker. Thought you might be interested in this issue :)

[mcartoixa]

Is it another manifestation of #680?

[krwq]

@mayankbansal018 @Evangelink do you have any ETA when this might be addressed? this is currently making vstests kinda useless in some scenarios for dotnet/iot because tests fail but we get not info what failed and issue is CI specific in our case.

[mcartoixa]

FYI #2702 addresses the issue, but has been waiting for ages now. I'm rebasing from time to time...

[nohwnd]

addressed in the msbuild logger work