Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly published version has outdated Readme on the gallery page #415

Closed
radeksimko opened this issue Jun 13, 2022 · 6 comments
Closed

Newly published version has outdated Readme on the gallery page #415

radeksimko opened this issue Jun 13, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@radeksimko
Copy link

radeksimko commented Jun 13, 2022

Describe the bug

We have released a new extension version on 9th June and it seems that Marketplace still did not invalidate the cached Readme from previous version it displays on the website, even after multiple days (today is 13th June), although at least it’s updated within VS Code.

https://github.com/hashicorp/vscode-terraform/blob/v2.23.0/README.md

Screenshot 2022-06-13 at 10 03 14

Screenshot 2022-06-13 at 10 03 26

Expected behavior

An up-to-date Readme shown on the gallery page.

Additional context

The mentioned extension has platform-specific builds, unsure if it matter though as we have been publishing it for some time now and this is pretty much the first time we noticed this problem.


cc @isidorn

@radeksimko radeksimko added the bug Something isn't working label Jun 13, 2022
@isidorn
Copy link
Collaborator

isidorn commented Jun 13, 2022

@radeksimko thanks for filling this issue.
Assigning to @prashantvc and fyi @SaiKanth007 since he was involved in previous issues like this and might have more details. Thanks

@ericdrobinson
Copy link

We believe that we recently ran afoul of this issue. Much of our experience is detailed in this discussion, but I will re-summarize here.

In our case, the extension in question is the ExtendScript Debugger. Versions 1.y.z were all deemed "Universal" as they predate the ability to specify targets. We submitted v2.0.0 last Thursday, specifying the list of supported targets and that's when the fun began.

On the machines we were able to test with (M1 Macs, to my knowledge), the README shown on the Marketplace was from the latest v1.y.z release available. The odd part here was that the README and CHANGELOG were the only things that didn't update on the website. The version update information and available versions were all properly listed. This made us suspicion of suggestions that "the README was being validated". Additionally, when viewing the extension from within VS Code on a supported platform, we were able to see the updated README as expected.

I attempted to view the same page with Safari using an overloaded User Agent (showing Intel instead of Apple Silicon) on the hunch that the Marketplace was attempting to show me something that would best match what I saw in VS Code on my system. There was no change.

The only idea remaining was that our 1.y.z version was considered Universal, which includes the web platform. Our new release did not include the web platform. Because we were viewing the Marketplace from "the web", perhaps the server was showing us the latest "web platform-compatible version available".

We pushed a new Universal version live (2.0.1) and then quickly pushed another platfrom-specific version live (2.0.2), restoring the expected target compatibility. The expected README became visible immediately.

We are currently operating under the assumption that the README shown on the web will show the latest web-compatible version even when not viewed from web-VS Code.

As mentioned here, the Marketplace really needs two things:

  1. A way to retroactively adjust the supported platforms for prior releases.
  2. Marketplace pages viewed from a browser should IGNORE platform specific limitations and show the latest version details.

@SaiKanth007
Copy link
Collaborator

@radeksimko @ericdrobinson This issue behind the stale readme on the gallery page is because of an issue with the marketplace cache. We have created a tracking issue to address this, we will try to prioritize this in our next sprint and work on it.

@glennsarti
Copy link

Still an issue :-(

@jpogran
Copy link

jpogran commented Aug 23, 2022

I'm happy to report the page now shows the correct content after we published a new release today. I'm unsure if this is because the caching issue was fixed and this issue not updated, or because of the new published extension.

@prashantvc
Copy link
Contributor

Thanks for the update @jpogran, please reopen the issue if you continue to see this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants