Fixes terminal drop overlay moves horizontally instead of vertically when pane is on the side #124985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanp413
commented
May 31, 2021
Comment on lines
+2035
to
+2040
| private _getViewOrientation(): Orientation { | ||
| const panelPosition = this._layoutService.getPanelPosition(); | ||
| const terminalLocation = this._viewDescriptorService.getViewLocationById(TERMINAL_VIEW_ID); | ||
| return terminalLocation === ViewContainerLocation.Panel && panelPosition === Position.BOTTOM | ||
| ? Orientation.HORIZONTAL | ||
| : Orientation.VERTICAL; |
There was a problem hiding this comment.
Had to copy this logic from TerminalGroup as I cannot use TerminalService.onPanelOrientationChanged to avoid a cyclic dependency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #124928