Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default styles and polish focus treatment #110748

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Update default styles and polish focus treatment #110748

merged 2 commits into from
Nov 16, 2020

Conversation

miguelsolorio
Copy link
Contributor

This PR address some of the issues from #109549

  • Updates default styles
  • Removes cell selection bg (color token is still there)
  • Updates cell focus color to use focusBorder color and creates a new token notebook.selectedCellBorder
  • Makes cell toolbar appear on hover instead of on focus (means only one toolbar is shown at a given time)
  • Adds a placeholder text in status bar when cell is focused (this needs to be localized)
  • Increased hit target for run and fold icons

ezgif com-gif-maker (6)

@miguelsolorio miguelsolorio added ux User experience issues polish Cleanup and polish issue notebook labels Nov 16, 2020
@miguelsolorio miguelsolorio added this to the November 2020 milestone Nov 16, 2020
rebornix
rebornix approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like how it's rendered now.

@miguelsolorio
Copy link
Contributor Author

Merging this so we can test out the styles.

@miguelsolorio miguelsolorio merged commit 274bf78 into master Nov 16, 2020
@miguelsolorio miguelsolorio deleted the misolori/notebook-styles branch November 16, 2020 22:34
@miguelsolorio miguelsolorio mentioned this pull request Nov 16, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

@roblourens roblourens Awaiting requested review from roblourens

Assignees

@roblourens roblourens

@rebornix rebornix

Labels
notebook polish Cleanup and polish issue ux User experience issues
Projects
None yet
Milestone
November 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelsolorio @rebornix @roblourens