Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening files from command line got very slow very recently #98400

Closed
nguerrera opened this issue May 22, 2020 · 5 comments · Fixed by #102011
Closed

Opening files from command line got very slow very recently #98400

nguerrera opened this issue May 22, 2020 · 5 comments · Fixed by #102011
Assignees
Labels
confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders windows VS Code on Windows issues
Milestone

Comments

@nguerrera
Copy link

nguerrera commented May 22, 2020

Issue Type: Bug

I'm not sure when it started happening, but it was within the last few days so I think there's a recent regression.

Steps to reproduce

  1. Start VS Code Insiders as usual
  2. Run code-insiders <any file> on the command line

Expected behavior

VS Code opens the file and takes focus relatively quickly

Actual behavior

It takes five or six seconds before VS code has focus with the file open and I can begin to type.

Notes

  • The problem reproduces with all extensions disabled (replacing step 1 with code-insiders --disable-extensions)
  • It does not reproduce with the stable version of VS Code
  • Everything else is performing fine. If I open files from the explorer, it's as instant as ever.
  • I tried profiling from developer tools. It doesn't appear to be registering any work during the long delay:

Profile-20200522T144153.zip

profile

VS Code version: Code - Insiders 1.46.0-insider (da98a19, 2020-05-20T22:21:02.272Z)
OS version: Windows_NT x64 10.0.18363

System Info
Item Value
CPUs AMD Ryzen Threadripper 1950X 16-Core Processor (32 x 3400)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 127.88GB (120.58GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (17)
Extension Author (truncated) Version
macros ctf 0.0.4
vscode-eslint dba 2.1.5
EditorConfig Edi 0.15.0
vscode-pull-request-github Git 0.16.1
vscode-test-explorer hbe 2.18.1
Lisp mat 0.1.10
csharp ms- 1.21.18
remote-wsl ms- 0.44.2
vsliveshare ms- 1.0.2236
debugger-for-edge msj 1.0.14
material-icon-theme PKi 4.1.0
toggle reb 0.0.1
vscode-yaml red 0.8.0
gitconfig sid 2.0.1
rewrap stk 1.10.1
emacs-mcx tut 0.19.6
vscodeintellicode Vis 1.2.7
@nickcoad
Copy link

nickcoad commented May 23, 2020

I don't have anything to add to your very thorough report, other than I've also experienced this on the latest Code Insiders so it's not just you. I'm also not quite sure when it started but it was only the last couple of days max.

@eamodio
Copy link
Contributor

eamodio commented May 25, 2020

See #97638

@nguerrera
Copy link
Author

I'm now seeing extreme lag when typing too, not sure if it's the same root cause. Let me know if there's any details I can share to help determine that.

@nguerrera
Copy link
Author

Got an update and this no longer repros. Still having some lagging typing, but I suspect that's altogether separate. I will file something else if it persists.

@deepak1556
Copy link
Collaborator

@nguerrera the slowdown was seen with an electron update, we reverted it temporarily. The underlying issue has not been fixed yet. I am reopening to investigate.

@deepak1556 deepak1556 reopened this May 29, 2020
@deepak1556 deepak1556 added confirmed Issue has been confirmed by VS Code Team member electron-8-update windows VS Code on Windows issues labels Jun 19, 2020
@bpasero bpasero added this to the July 2020 milestone Jul 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders windows VS Code on Windows issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@nguerrera @eamodio @bpasero @deepak1556 @nickcoad and others