Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: 'Disconnect' icon should be different than 'Stop' #9740

Closed
joaomoreno opened this issue Jul 26, 2016 · 9 comments
Closed

Debug: 'Disconnect' icon should be different than 'Stop' #9740

joaomoreno opened this issue Jul 26, 2016 · 9 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues invalid Issue identified as not relevant or not valid ux User experience issues
Milestone

Comments

@joaomoreno
Copy link
Member

Currently we use the same Stop icon for both Stop and Disconnect actions. It would be more intuitive to use an icon that confers the idea of a disconnection when the Disconnect action is in place.

cc @bgashler1

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues ux User experience issues labels Jul 26, 2016
@isidorn
Copy link
Contributor

isidorn commented Jul 26, 2016

Makes sense, @bgashler1 could you provide one such icon?

@bgashler1
Copy link
Contributor

@isidorn this is the closest icon I have to disconnect. If this works, I can give you both light and dark versions of it.

disconnect_16x

For clarification, is this in place of the Stop icon when debugging inside the floating debug menu? Could you show me a screenshot of how this is currently in the product? Thanks!

@joaomoreno
Copy link
Member Author

Looks good!

Yes, it is in place of the last icon in the screenshot:

image

@bgashler1
Copy link
Contributor

bgashler1 commented Aug 18, 2016

@isidorn
Just found out that Visual Studio uses a different icon. We should probably remain consistent and use this (see below)
image003


Here are the icons. The correct one to use is in folder "02 use this"

Disconnect icon.zip

@joaomoreno
Copy link
Member Author

joaomoreno commented Aug 18, 2016

Not the biggest fan of that icon. Not only it has a different aesthetics than the other icons (looks like two crossed handmade brush strokes, while the others are cleaner, less human), but also doesn't convey any disconnect semantics, unlike the one you posted 2 comments above.

@bgashler1
Copy link
Contributor

@joaomoreno I hear you and can see why you feel that way. @isidorn do you agree with him?

@isidorn
Copy link
Contributor

isidorn commented Aug 22, 2016

I agree with the points @joaomoreno made about the X icon. Another downside is that we previously used this icon in a lot of places but removed it everywhere. I do not see why we would go back to using it.
So I will go with the first proposal, which I think will work nicely.

@bgashler1
Copy link
Contributor

Sounds good. You'll find those assets in the same zip file under the other folder.

@bpasero bpasero added invalid Issue identified as not relevant or not valid and removed bug Issue identified by VS Code Team member as probable bug labels Sep 1, 2016
@bpasero
Copy link
Member

bpasero commented Sep 1, 2016

Obsolete

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues invalid Issue identified as not relevant or not valid ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants