Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot navigate problems across cells #96708

Closed
sandy081 opened this issue Apr 30, 2020 · 5 comments
Closed

Cannot navigate problems across cells #96708

sandy081 opened this issue Apr 30, 2020 · 5 comments
Assignees
@jrieken
Labels
feature-request Request for new features or functionality notebook on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2020

Comments

@sandy081
Copy link
Member

Testing #96279

  • Have two GitHub issues cells that has problems
  • Open marker peek in one of the cells
  • Use navigation (up and down) arrows in the peek
    🐛 This navigates only in the cell

Kapture 2020-04-30 at 16 31 55
@sandy081 sandy081 mentioned this issue Apr 30, 2020
Closed
@jrieken
Copy link
Member

jrieken commented Apr 30, 2020

Sorry - you own this feature 🙊

@sandy081
Copy link
Member Author

Yup and it is scoped to single text document just like outline. Seems this also needs adopted for Notebooks.

@sandy081 sandy081 added feature-request Request for new features or functionality notebook labels Apr 30, 2020
@sandy081 sandy081 modified the milestones: Backlog Candidates, Backlog Apr 30, 2020
@jrieken
Copy link
Member

jrieken commented Apr 30, 2020

Yeah - this is actually more interesting and we have to see how we make this work...

@rebornix
Copy link
Member

For problem navigation, or any other similar features, previously we always build two actions/commands:

  • navigate in current document
  • navigate in workspace

Now with composite editors concept, we need an action which allows you navigate in the composite editors. IMHO we need to introduce this concept into all language features in a generic way.

@jrieken jrieken modified the milestones: Backlog, May 2020 May 1, 2020
jrieken added a commit that referenced this issue May 4, 2020
@jrieken
make goto error widget action a menu and contribute navigation comman…
27db1be 
…ds to it, #96708
@jrieken jrieken assigned jrieken and unassigned jrieken and sandy081 May 11, 2020
jrieken added a commit that referenced this issue May 11, 2020
@jrieken
rework gotoError logic to be fit for #96708
136bbd3
jrieken added a commit that referenced this issue May 11, 2020
@jrieken
add marker list provider, #96708
337c788
jrieken added a commit that referenced this issue May 11, 2020
@jrieken
register a marker list provider for notebooks, #96708
2b472d1
@jrieken jrieken closed this as completed May 11, 2020
@jrieken jrieken added the verification-needed Verification of issue is requested label May 29, 2020
@connor4312 connor4312 added the verified Verification succeeded label Jun 3, 2020
@jrieken jrieken added the on-release-notes Issue/pull request mentioned in release notes label Jun 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality notebook on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
5 participants
@rebornix @jrieken @connor4312 @sandy081 and others