Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark+ theme changed between 1.44 & 1.45 #95434

Closed
GongT opened this issue Apr 16, 2020 · 5 comments
Closed

Dark+ theme changed between 1.44 & 1.45 #95434

GongT opened this issue Apr 16, 2020 · 5 comments
Assignees

Comments

@GongT
Copy link

GongT commented Apr 16, 2020

  • VSCode Version: insider 1.45.0
  • OS Version: Win 10 x64

← 1.44 | 1.45 →

image

and this icon seems broken.
image

Does this issue occur when all extensions are disabled?: Yes

@robertrossmann
Copy link
Contributor

I suspect this is due to Semantic Highlighing being enabled by default in one of the latest updates... 🤔 You can try to turn it off in your Settings - editor.semanticHighlighting.enabled.

@IllusionMH
Copy link
Contributor

IllusionMH commented Apr 16, 2020

  1. Difference in highlight - most likely this is due semantic highlight (as mentioned above)

  2. Found same issue with icon - reported in Account icon looks incorrectly in Insiders build #95437

@IllusionMH
Copy link
Contributor

IllusionMH commented Apr 16, 2020

After reload I can confirm change in hightlight only started in today's build and looks like this is new color for constant values which is strange (especially after they were colored as functions before).

@aeschli can you clarify what changed here?
Looks worse than before especially with chosen color (as usually with any change in highlight 😄 )

I see crossed foreground entity.name.function { "foreground": "#DCDCAA" } in the end for scopes info block.

UPD. Found #95346 but I think that value on constant (that was used before) should have priority over generic knowledge that variable is constant.

@joaomede
Copy link

joaomede commented Apr 16, 2020

I updated today and realized that "editor.semanticHighlighting.enabled: false" does not work on false, it seems that some themes receive the same white color, see
this commit b02307e

@aeschli
Copy link
Contributor

aeschli commented Apr 17, 2020

dup of #95346

The change of color for consts in a test run in Insiders. Please give it a chance and please add a thumbs up/down on that issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants