Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal font render size connecting external displays #94656

Closed
aladinoster opened this issue Apr 8, 2020 · 2 comments
Closed

Terminal font render size connecting external displays #94656

aladinoster opened this issue Apr 8, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone

Comments

@aladinoster
Copy link

  • VSCode Version: 1.43.2
  • OS Version: OS X 10.15.1

Steps to Reproduce:

  1. Open VSCode, open a terminal
    Screenshot 2020-04-08 at 07 44 04

  2. Connect an external display, then the font renders in a small way
    Screenshot 2020-04-08 at 07 43 26

  3. Disconnecting the external display comes to this situation

Screenshot 2020-04-08 at 07 42 57

I'm currently using these settings for the terminal:

"terminal.integrated.fontFamily": "Source Code Pro for Powerline, 'SourceCodePro+Powerline+Awesome Regular'",
    "terminal.integrated.fontWeightBold": "600",
    "terminal.integrated.fontSize": 14,
    "terminal.integrated.showExitAlert": false,
    "terminal.external.osxExec": "iTerm.app",
    "terminal.integrated.copyOnSelection": true,
    "terminal.integrated.cursorStyle": "line",
    "terminal.integrated.cursorBlinking": true,
    "terminal.integrated.rendererType": "experimentalWebgl",
    "terminal.integrated.inheritEnv": false,
    "terminal.integrated.minimumContrastRatio": 4.5,

I've already read #28747, #6196 and it seems the problem is due to electron and only windows reported.

Does this issue occur when all extensions are disabled?: Yes/No

@Tyriar
Copy link
Member

Tyriar commented Apr 8, 2020

/duplicate xtermjs/xterm.js#2137

@Tyriar Tyriar closed this as completed Apr 8, 2020
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream and removed *duplicate Issue identified as a duplicate of another issue(s) labels May 2, 2020
@Tyriar Tyriar added this to the May 2020 milestone May 2, 2020
@Tyriar Tyriar reopened this May 2, 2020
@Tyriar
Copy link
Member

Tyriar commented May 11, 2020

I think this has been pulled in.

@Tyriar Tyriar closed this as completed May 11, 2020
@Tyriar Tyriar added the upstream-issue-fixed The underlying upstream issue has been fixed label May 11, 2020
@lramos15 lramos15 added the verified Verification succeeded label Jun 4, 2020
@JacksonKearl JacksonKearl added verified Verification succeeded and removed verified Verification succeeded labels Jun 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@Tyriar @lramos15 @JacksonKearl @aladinoster and others