Workspace folders from different providers

[dbaeumer]

When I use LSIF together with WSL I always get this message:

Why do we have this limitation? I don't see this under Windows since there I have a normal file provider.

[bpasero]

From 0e6822b

[dbaeumer]

@isidorn can you explain the underlying reason for this.

[isidorn]

@dbaeumer we do not allow workspace folders with different schemas. We always had this limitation - the exact reason I forgot to be honest.
Here are some issues with more details
https://github.com/microsoft/vscode-remote/issues/1608
#75273
Also @aeschli might know more since I remember him being the original person that I discussed this with.

[aeschli]

@isidorn We want to prevent that local folders are added to remote workspaces. Your check prevents too much.
Can you change the check to

if (this.environmentService.configuration.remoteAuthority) {
   foldersToAdd = foldersToAdd.filter(f => f.uri.scheme !== Schemas.file);
}

also remote folders from different remotes should be disallowed:

const remoteAuthority = this.environmentService.configuration.remoteAuthority;
if (remoteAuthority) {
   foldersToAdd = foldersToAdd.filter(f => f.uri.scheme !== Schemas.file && (f.uri.scheme !== Schemas.vscodeRemote || hasEqualAuthority(f.uri.authority, remoteAuthority)));
}

[isidorn]

@aeschli thanks for refershing my memory.
Yes, we can loosen the check. Let's do that start of next week.

[dbaeumer]

@isidorn & @aeschli Thanks. Will make my LSIF live easier.