Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook top border for no defintion found cutoff #93930

Closed
isidorn opened this issue Mar 31, 2020 · 2 comments · Fixed by #94195
Closed

Notebook top border for no defintion found cutoff #93930

isidorn opened this issue Mar 31, 2020 · 2 comments · Fixed by #94195
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone
April 2020

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

Refs: #93742

Notebook, do a go to definition on a symbol which does not have a definition.
Notice the top border is cutoff on the message that no defintion could be found.
Same for other similar messages (like no references found)

Screenshot 2020-03-31 at 15 05 53
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Mar 31, 2020
@rebornix rebornix added this to the April 2020 milestone Mar 31, 2020
This was referenced Apr 1, 2020
Closed
Merged
Closed
@isidorn
Copy link
Contributor Author

isidorn commented Apr 30, 2020

This is not fixed for me with latest. It is fine to push out to next milestone imho.

Screenshot 2020-04-30 at 12 01 27

@isidorn isidorn reopened this Apr 30, 2020
@jrieken jrieken removed their assignment Apr 30, 2020
@rebornix
Copy link
Member

Good catch, the zindex needs to be applied to all overflowing content widgets.

image

image

@RMacfarlane RMacfarlane added the verified Verification succeeded label May 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

Successfully merging a pull request may close this issue.

Fix widget in cell editor cutoff by the titlebar. microsoft/vscode
4 participants
@rebornix @jrieken @isidorn @RMacfarlane