Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default choices in the integrated terminal dropdown menu. #9353

Closed
gerane opened this issue Jul 15, 2016 · 4 comments
Closed

Add default choices in the integrated terminal dropdown menu. #9353

gerane opened this issue Jul 15, 2016 · 4 comments

Comments

@gerane
Copy link

gerane commented Jul 15, 2016

It can be a pain trying to help someone properly setup a 64 bit cmd or PowerShell terminal. Since Code uses %comspec% as it's default terminal, this breaks a lot of things on 64 bit machines.

To make dealing with this easier, I think there should be a drop down similar to the terminal selection one where we can configure multiple terminals. Then Code can add some of the native ones as default values and allow users to add new ones.

Example on windows 64bit:

"terminal.integrated.shell.windows.options": { 
    "PowerShell (x64)": "C:\\WINDOWS\\sysnative\\WindowsPowerShell\\v1.0\\powershell.exe",
    "PowerShell (x86)": "C:\\WINDOWS\\system32\\WindowsPowerShell\\v1.0\\powershell.exe",
    "Cmd (x64)": "C:\\WINDOWS\\sysnative\\cmd.exe",
    "Cmd (x86)": "C:\\WINDOWS\\system32\\cmd.exe"
}

Example on windows 32bit:

"terminal.integrated.shell.windows.options": { 
    "PowerShell": "C:\\WINDOWS\\system32\\WindowsPowerShell\\v1.0\\powershell.exe",
    "Cmd": "C:\\WINDOWS\\system32\\cmd.exe"
}

You could also do something to add Shell Args in there as well, which I am really hoping Windows gets some day.

@Tyriar
Copy link
Member

Tyriar commented Jul 15, 2016

Since it's just a one-time configuration I wouldn't want to add chrome to the UI for this, especially since settings aren't applied anywhere on the UI. It would go against the minimalistic/lightweight value of VS Code. The documentation was just updated yesterday which recommends sysnative for cmd, powershell and bash. https://code.visualstudio.com/docs/editor/integrated-terminal#_configuration

Closing this as designed, let's continue the conversation over in #7095

@Tyriar Tyriar closed this as completed Jul 15, 2016
@gerane
Copy link
Author

gerane commented Jul 17, 2016

Is there any plans for supporting multiple types of terminals? Say I have 1 terminal for CMD, another for PS and maybe a 3rd custom that are all open and can be switched between.

@Tyriar
Copy link
Member

Tyriar commented Jul 17, 2016

No plans, you can probably accomplish this by running powershell from within cmd and vice versa.

@Tyriar
Copy link
Member

Tyriar commented Aug 21, 2017

Support for multiple terminal configs s deferred to this extension for now https://marketplace.visualstudio.com/items?itemName=Tyriar.shell-launcher

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants