Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: QuickFix for renaming afterwards, instead pressing F2 before rename. #90361

Closed
mbodm opened this issue Feb 10, 2020 · 9 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality rename

Comments

@mbodm
Copy link

mbodm commented Feb 10, 2020

Please introduce renaming of variables AFTER we renamed a variable, via QuickFix, like VS do.

Having in mind to always press F2 first, to rename, is horrible. Changing a name of a variable and say "reflect that to all uses of that variables" AFTERWARDS, is imo 100 times better.

And nearly every modern IDE has this feature.

@vscodebot
Copy link

vscodebot bot commented Feb 10, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@jrieken jrieken added feature-request Request for new features or functionality rename labels Feb 11, 2020
@jrieken jrieken modified the milestones: Backlog, Backlog Candidates Feb 11, 2020
@vscodebot
Copy link

vscodebot bot commented Feb 11, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@jrieken
Copy link
Member

jrieken commented Feb 11, 2020

related to #88424

@mbodm
Copy link
Author

mbodm commented Feb 12, 2020

Maybe my english is not good enough (i am not a native english speaker), but my suggestion has in no way anything in common with either Issue 87853 nor with Issue 88424.

At least, as far as i can see.

@gjsjohnmurray
Copy link
Contributor

@mbodm 87853 was suggested by the bot but is irrelevant. As I understand 88424 its idea of synced regions would provide a foundation for rename to be triggered by editing, without having to use F2.

@mbodm
Copy link
Author

mbodm commented Feb 26, 2020

@mbodm 87853 was suggested by the bot but is irrelevant. As I understand 88424 its idea of synced regions would provide a foundation for rename to be triggered by editing, without having to use F2.

My suggestion is not about a direct change of all occurences of a variable name, when renaming that variable (while typing).

Its about changing the name of a variable at the definition of that variable, lets say from
let bunny = 'hop'; to let ape = 'eat banana;'
and afterwards a quick action tells you "Rename all occurences of 'bunny' to 'ape'." and if you execute the quick action, all bunny occurences are renamed to ape.

Did none of you ever used Visual Studio 2013, 2015 or 2019 ? Or Rider ? Or Android Studio ? Or whatever. They all use this feature.

Do not get it.

@mbodm
Copy link
Author

mbodm commented Feb 26, 2020

Hmm,

not to be salty here, but it seems there is less hope for a standard feature, every halfway modern development IDE has since years, when even a member of the VS Code development team (at least it seems @jrieken is one of them) thinks this suggestion is related to a totally another issue/suggestion.

I assume (because it is a standard feature) there are a lot of ppl out there would like to see this quick action added. But none of these ppl ever find suggestions like this, or use the issues at all.

And since this suggestion will become either closed (because not even 20 upvotes will be reached), or lands in the backlog for ages, and obviously the devs not feel this feature as needed (otherwise it would exist since years), i assume this suggestion will dive into the shadows. :-/

Do not get the mindset of VS Code (or the team behind it) here at all. Maybe a technical aspect, but when i look at what VS Code is able to do, with quick actions and JS, i think it is more a design-, mind-, or taste-thing, than a technical hurdle or difficult to implement. Of course, JS is not a type safe language like C#, where stuff in that regards is way more easy. But i think it is not that complex, when you have a F2 rename feature, to implement the same thing, as quick action, after renaming of a variable.

On the other side, i also not understand the state of the VS Code team in the slightest, when it comes down to the issues about the VS Code problem in Node.js projects, to mark the first (commonJS) require statement with a "Change to ecma2015 import statement" quick action. So the dev team maybe has another point of view to some things, than me and the developers i know. :-)

PS: Hi @jrieken, i think you are just around 70 KM beeline away from here. So best regards to Wallisellen. :-)

@vscodebot
Copy link

vscodebot bot commented Apr 1, 2020

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding

@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality rename
Projects
None yet
Development

No branches or pull requests

4 participants
@jrieken @gjsjohnmurray @mbodm and others