Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html] [rename on type] does not work properly with multicursor #88127

Closed
plezan opened this issue Jan 6, 2020 · 0 comments
Closed

[html] [rename on type] does not work properly with multicursor #88127

plezan opened this issue Jan 6, 2020 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-synced-region Issues related to synced region functionality in editor insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@plezan
Copy link

plezan commented Jan 6, 2020

There is an inconsistency in the behaviour of the new mirror cursor feature

Depending on the way used to select multiple opening tags it won't have a constant behavior :

  • when using alt+maj+down to select :
<td| headers="row1 col1">1 973</td|>
<td| headers="row1 col2">770</td> |
<td| headers="row1 col3">14</td> |
<td| headers="row1 col4">22</td> |
<td| headers="row1 col5">40</td> |
  • when using alt+click
<td| headers="row1 col1">1 973</td|>
<td| headers="row1 col2">770</td> 
<td| headers="row1 col3">14</td> 
<td| headers="row1 col4">22</td> 
<td| headers="row1 col5">40</td> 
  • when using ctrl+d
<td| headers="row1 col1">1 973</td>
<td| headers="row1 col2">770</td> 
<td| headers="row1 col3">14</td> 
<td| headers="row1 col4">22</td> 
<td| headers="row1 col5">40</td> 

Maybe the simpler solution would be to disable it with the multi cursor, like when using ctrl+d or double-clicking (as in #86052)

  • VSCode Version: 1.41.1
  • OS Version: Linux x64 5.0.0-37-generic snap (Ubuntu 19.04)

Steps to Reproduce:

  1. use multiple cursors in opening tags
  2. press

Does this issue occur when all extensions are disabled?: Yes

@octref octref added bug Issue identified by VS Code Team member as probable bug editor-synced-region Issues related to synced region functionality in editor labels Jan 10, 2020
@octref octref added this to the Backlog milestone Jan 10, 2020
@aeschli aeschli assigned aeschli and unassigned octref May 4, 2020
@aeschli aeschli changed the title [html] Mirror Cursor does not work properly with multicursor [html] [rename on type] does not work properly with multicursor May 4, 2020
@aeschli aeschli modified the milestones: Backlog, August 2020 Aug 18, 2020
@jrieken jrieken added the verified Verification succeeded label Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-synced-region Issues related to synced region functionality in editor insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@jrieken @octref @aeschli @plezan and others