Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems: selecting problem should highlight problem line in editor #8365

Closed
weinand opened this issue Jun 28, 2016 · 2 comments
Closed

Problems: selecting problem should highlight problem line in editor #8365

weinand opened this issue Jun 28, 2016 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view verified Verification succeeded

Comments

@weinand
Copy link
Contributor

weinand commented Jun 28, 2016

Testing #7601:

Single clicking an item in the problems view reveals the problem in the editor.
But if the problem is only flagged with a squiggly for a single character, it is very difficult to spot the problem.

In the example below try to quickly spot the problem in the editor after the item has been selected in the problems view:

2016-06-28_15-34-11

It would be helpful if the line of the problem could be highlighted briefly.

@sandy081 sandy081 added the error-list Problems view label Jul 5, 2016
@sandy081 sandy081 added this to the July 2016 milestone Jul 5, 2016
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Jul 5, 2016
@sandy081 sandy081 modified the milestones: Backlog, July 2016 Jul 26, 2016
@sandy081
Copy link
Member

sandy081 commented Sep 8, 2016

Verification:

Note: Line highlight used should be same as in Find / Search / Go to line / Outline

  • Single click on the problem -> Line highlight is shown.
  • Type Space on the problem -> Line highlight is shown.
  • Toggle Problems view -> Line highlight is also toggled.
  • Click inside editor -> Line highlight is removed.
  • Double click on the problem -> No line highlight is shown.
  • When Problems view is hidden, no line highlights from problems view are shown.
  • When problem is fixed, no line highlights are shown.

@bpasero bpasero added the verified Verification succeeded label Sep 29, 2016
@bpasero
Copy link
Member

bpasero commented Sep 29, 2016

Verified that clicking a problem shows the line highlighted. I think the rest was part of the test plan.

@sandy081 sandy081 modified the milestones: September 2016, Backlog Sep 30, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug error-list Problems view verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants