Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo action on Find/Replace widget should undo in the editor #8350

Closed
sandy081 opened this issue Jun 28, 2016 · 3 comments
Closed

Undo action on Find/Replace widget should undo in the editor #8350

sandy081 opened this issue Jun 28, 2016 · 3 comments
Assignees
Labels
ux User experience issues

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 28, 2016

#8229

Safari

Steps to Reproduce:

  1. Open Find/Replace widget
  2. Type a find term and replace term
  3. Press Enter to replace
  4. Do undo

Expected: This should undo the replace
Actual: This is calling browser undo

@alexdima
Copy link
Member

@sandy081 Where is the focus when you undo? The UI element that has focus should handle undo. If your focus is in the replace input box, then that input box should handle the undo. Or you think that is unexpected?

@sandy081
Copy link
Member Author

Focus is in replace input box. I think in this case, it would be nice to undo the last replace done in the editor.

@alexdima
Copy link
Member

I don't agree. In my opinion, each input box should have its own undo stack that allows you to undo mistakes. We can discuss this in next's week UX meeting.

@alexdima alexdima added ux User experience issues editor and removed monaco-editor labels Jun 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ux User experience issues
Projects
None yet
Development

No branches or pull requests

2 participants