Loose IntelliSense for angularjs updating from 0.10.9

[miguelchico]

• VSCode Version: 1.2.1
• OS Version: Windows 7

Steps to Reproduce:
I´m moving from version 0.10.9 to 1.2.1 and I´ve lost IntelliSense information

1. Create a project
2. Create an angular 1 controller like this:
   
3. Create a jsconfig.json like this:

4. Using typings install angular TypeScript definition

In version 0.10.9 IntelliSense was working in all places I needed in this controller.
It was working in angular:

And it also was working in injected dependencies:

From version 0.10.11 the IntelliSense information for the same file and same project is different.
It still work in angular but it doesn't for injected dependencies anymore:

I've tried with versions 0.10.11 and 1.2.1 and it doesn't work.
I've checked the release notes from 0.10.9 to 1.10.11 and the main difference was the inclusion of Salsa, but I couldn't find any change I have to do in my project to keep it working.

Any suggestion?

[dbaeumer]

@egamma assigning to you since you provided quite some support for people switching over to Salsa.

[egamma]

@miguelchico we are sorry, but support for intellisense for injected dependencies has been lost as part of the migration to the new Salsa implementation.

[egamma]

@miguelchico did you try to type the injected dependencies using JS Doc comments?
https://code.visualstudio.com/docs/languages/javascript#_intellisense

[miguelchico]

@egamma that's a pitty....

Yes, I tried using JS Doc comments and it works, but now I have to write a lot of types manually in my comments and maintain them.

There is no play to get back the support?

Thank you.

[egamma]

@miguelchico

There is no play to get back the support?

To be honest, we did something very 'pragmatic'/hackish to enable this in the past. pls file a feature request against the TypeScript project https://github.com/Microsoft/TypeScript/issues/new

[bmontgom]

@miguelchico Did you ever file a feature request? I'm wanting this feature as well.

[miguelchico]

I've done right know.

microsoft/TypeScript#9600

@egamma, could you please check if it's what you needed?

[bmontgom]

Thanks, @miguelchico.
@egamma, is this something that will be difficult for the VSCode team to do, and as such should I expect this to take a long time (more than a month) to become available again?

[egamma]

@miguelchico issue LGTM, thanks.

@bmontgom the JS language service is done by the TS team, if they do it (will talk to them), then it would be in a future TypeScript release.

Closing this issue, since it is now tracked in TypeScript repository.

[egamma]

@bmontgom @miguelchico one immediate workaround would be to augment one of the JSDoc comment generator extensions and make it angular aware so that it generates the JSDoc comments.

https://marketplace.visualstudio.com/items?itemName=stevencl.addDocComments
https://marketplace.visualstudio.com/items?itemName=joelday.docthis