Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode holds *.asar file locked though I've even did not open it in editor, which leads to "The process cannot access the file because it is being used by another process." #80146

Closed
ivictbor opened this issue Aug 31, 2019 · 7 comments
Assignees

Comments

@ivictbor
Copy link

ivictbor commented Aug 31, 2019

  • VSCode Version: 1.37.1
  • OS Version: Windows_NT x64 10.0.17763

Steps to Reproduce:

  1. Open sources of app app which includes *.asar resources with electron-builder
  2. Run npm run build
  3. build fails win-unpacked\resources\app.asar: The process cannot access the file because it is being used by another process.
  4. Process explorer shows that is holder by vscode

image

Does this issue occur when all extensions are disabled?: Yes/No
Yes, tried code --disable-extensions, Open Folder.

@ivictbor
Copy link
Author

Duplicate of #62518 (comment) , but that one was not fixed

@chrmarti chrmarti assigned bpasero and alexdima and unassigned chrmarti Sep 2, 2019
@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron labels Sep 2, 2019
@bpasero
Copy link
Member

bpasero commented Sep 2, 2019

@ivictbor in that screenshot, what is the full command line of the Code process that locks the asar file? Trying to understand which of our processes this is.

@bpasero bpasero added the info-needed Issue requires more information from poster label Sep 2, 2019
@ivictbor
Copy link
Author

ivictbor commented Sep 2, 2019

@bpasero thanks for reply, here how it looks, though it has no code --disable-extensions, maybe reason in that fact I used file -> open recent and it restarted vscode with extensions again

image

@bpasero bpasero assigned dbaeumer and octref and unassigned bpasero and alexdima Sep 2, 2019
@bpasero bpasero removed electron Issues and items related to Electron info-needed Issue requires more information from poster upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Sep 2, 2019
@bpasero
Copy link
Member

bpasero commented Sep 2, 2019

@dbaeumer looking at it this seems to be a language server. Didn't you recently push a change there to disable asar support?

@dbaeumer
Copy link
Member

dbaeumer commented Sep 3, 2019

This got fixed in the LSP libraries lately. I think it got introduced when @alexandrudima added asar support to the extension host and removed the env when starting it. Commit is microsoft/vscode-languageserver-node@1e7962e

@dbaeumer dbaeumer closed this as completed Sep 3, 2019
@octref
Copy link
Contributor

octref commented Sep 3, 2019

@dbaeumer Is there a new version I can adopt?

@dbaeumer
Copy link
Member

dbaeumer commented Sep 3, 2019

No, will come out this week.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants