Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode auto completes certain patterns without consent #78650

Closed
Nuc1eoN opened this issue Aug 7, 2019 · 6 comments
Closed

vscode auto completes certain patterns without consent #78650

Nuc1eoN opened this issue Aug 7, 2019 · 6 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster suggest IntelliSense, Auto Complete

Comments

@Nuc1eoN
Copy link

Nuc1eoN commented Aug 7, 2019

Ok so this happened for me on a few different occasions and I think it really should be fixed. I have a few patterns in mind that trigger the bug, but lets go with the one everybody should be able to reproduce instantly:

  1. Create a .js file
  2. Type ul.

Upon writing the dot . vscode autocompletes the expressions to either URL. or userList. on my side. I can 100% reproduce this every time, with all of my extensions disabled.

So I am pretty sure vscode is not supposed to automagically replace strings without pressing enter or TAB

As I said there have been other patterns also triggering this, but lets go with the above mentioned example for now, as it seems very simple to reproduce and maybe all those occurrences have the same root cause.

@gjsjohnmurray
Copy link
Contributor

For .js and .ts files the dot is a completion character, and the setting editor.acceptSuggestionOnCommitCharacter defaults to true.

See #70176 (comment)

@jrieken jrieken added info-needed Issue requires more information from poster suggest IntelliSense, Auto Complete labels Aug 8, 2019
@jrieken
Copy link
Member

jrieken commented Aug 8, 2019

What version is this? This is likely a duplicate of #77926

@Nuc1eoN
Copy link
Author

Nuc1eoN commented Aug 8, 2019

For .js and .ts files the dot is a completion character, and the setting editor.acceptSuggestionOnCommitCharacter defaults to true.

Yes disabling that fixes it, even though I would consider this to be a very unintuitive default.

Also I still think this might be some kind of a bug since it is not consistent at all what will be autocompleted. As I have mentioned, ul. gets randomly converted to either URL. or userList..

What version is this? This is likely a duplicate of #77926

Might be! I'm on v1.36.1

One other case was, that writing something like .style would get autocompleted to .getElementsByClassName, however I currenlty didnt find a way to trigger it in a reproducable manner. You can see the issue here: https://youtu.be/hdI2bqOjy3c?t=5261

@jrieken
Copy link
Member

jrieken commented Aug 9, 2019

Might be! I'm on v1.36.1

Very, very likely. Closing as duplicate, please report back if this happens with 1.37 (released yesterday)

@jrieken jrieken added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 9, 2019
@vscodebot
Copy link

vscodebot bot commented Aug 9, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Aug 9, 2019
@Nuc1eoN
Copy link
Author

Nuc1eoN commented Aug 14, 2019

Hey, seems it is still happening with v1.37

I can definately still reproduce the .ul issue described above in .js files

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster suggest IntelliSense, Auto Complete
Projects
None yet
Development

No branches or pull requests

3 participants