Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown extension / webview: Focus border #7067

Closed
kieferrm opened this issue May 31, 2016 · 3 comments
Closed

Markdown extension / webview: Focus border #7067

kieferrm opened this issue May 31, 2016 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@kieferrm
Copy link
Member

  1. Using the markdown extension (Extract the MarkDown editor into an extension #6106) open a preview of a markdown file
  2. Open command pallet
  3. Close pallet by clicking into the preview
    -> focus border

7rry5cydg1

I haven't found a styling yet that solves the issue.

@kieferrm kieferrm changed the title Markdown extensions / webview: Focus border Markdown extension / webview: Focus border May 31, 2016
@bpasero
Copy link
Member

bpasero commented Jun 1, 2016

When quick open is closing it calls the focus() method of the active editor. It is up to the implementor of the editor (in this case the htmlPreviewPart) to do something then. We seem to call focus() on the and this brings up the native outline.

If we add a rule to our shell.css (in https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-browser/media/shell.css#L174) to have no outline for webviews, this issue is fixed.

.monaco-shell .part.editor .iframe-container,
.monaco-shell .part.editor .binary-container,
webview {
    outline: 0 !important;
}

@jrieken jrieken self-assigned this Jun 1, 2016
@jrieken jrieken added this to the June 2016 milestone Jun 1, 2016
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug editor labels Jun 1, 2016
@jrieken
Copy link
Member

jrieken commented Jun 1, 2016

This fix should go in the previewPart

@jrieken jrieken closed this as completed in 5373d60 Jun 1, 2016
@kieferrm
Copy link
Member Author

kieferrm commented Jun 2, 2016

The change is not working since the outline style is not applied to the webview but to the body of the displayed document(s).

@kieferrm kieferrm reopened this Jun 2, 2016
@bpasero bpasero added the verified Verification succeeded label Jul 4, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants