Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalize markdown extension #7065

Closed
kieferrm opened this issue May 31, 2016 · 3 comments
Closed

Internationalize markdown extension #7065

kieferrm opened this issue May 31, 2016 · 3 comments
Assignees
Labels
markdown Markdown support issues

Comments

@kieferrm
Copy link
Member

For #6106:

Support the core vscode UI languages.

@jrieken
Copy link
Member

jrieken commented May 31, 2016

@dbaeumer can help. There is a story that we have used for the TypeScript extension and others

@dbaeumer
Copy link
Member

dbaeumer commented Jun 1, 2016

Yes, we do have full support to externalize strings in extensions. All extensions in the vscode repository should be externalized so what we for example do in TS or JSON can be copied.

If markdown moves to its own repository and out of vscode then the story is more or less the same. You can use vscode-nls to do the string marking as in the normal extension code. To do the actual string extraction during build time there is another npm module that can be used called vscode-nls-dev.

Although not an extension vscode-node-debug uses both npm modules to do their internationalization work.

@kieferrm please ping me if you need any additional information.

@kieferrm
Copy link
Member Author

Only requires the package.json files to use keys that are resolved in the package.nls.json file. Everything afterwards is handled automatically. Nothing else todo.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
markdown Markdown support issues
Projects
None yet
Development

No branches or pull requests

3 participants