Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Chars are ALWAYS UPPERCASE on MacOSX when 'keyboard Caps on' #69367

Closed
lxx2013 opened this issue Feb 25, 2019 · 11 comments · Fixed by xtermjs/xterm.js#3728
Closed

Terminal Chars are ALWAYS UPPERCASE on MacOSX when 'keyboard Caps on' #69367

lxx2013 opened this issue Feb 25, 2019 · 11 comments · Fixed by xtermjs/xterm.js#3728
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@lxx2013
Copy link

lxx2013 commented Feb 25, 2019

Issue Type: Bug
image

Mac's default style of 'UpperCase or LowerCase' is widely-known as follows:

  1. when 'Caps off && Shift off', It maybe 'Chinese IME'
  2. when 'Caps on && Shift off', It is 'English LowerCase mode'
  3. when 'Caps on && Shift on' , It is 'English UpperCase mode'

But the terminal in the vscode of version 1.31.1 didn't display correctly at scene 2.

VS Code version: Code 1.31.1 (1b8e830, 2019-02-12T02:16:38.656Z)
OS version: Darwin x64 17.5.0, OSX 10.13.4

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 3600)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: unavailable_off
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 1, 2, 2
Memory (System) 16.00GB (2.49GB free)
Process Argv -psn_0_307275
Screen Reader no
VM 0%
Extensions (21)
Extension Author (truncated) Version
stylus Ala 0.0.4
doxdocgen csc 0.4.1
app-migrator deb 0.0.6
EditorConfig Edi 0.13.0
lex-flex-yacc-bison fau 0.0.3
vscode-flow-ide gca 1.2.0
vscode-gutter-preview kis 0.17.5
vscode-language-pack-zh-hans MS- 1.31.4
python ms- 2019.1.0
cpptools ms- 0.21.0
debugger-for-chrome msj 4.11.2
vetur oct 0.16.2
minapp-vscode qiu 1.12.1
sass-indented rob 1.5.1
vue-vscode-snippets sdr 1.3.0
code-settings-sync Sha 3.2.5
fantastical-vuejs-code sld 0.1.2
stylus-supremacy thi 2.12.7
vscode-import-cost wix 2.12.0
html2jade wma 0.2.0
JavaScriptSnippets xab 1.7.2

(2 theme extensions excluded)

@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Feb 25, 2019
@Tyriar
Copy link
Member

Tyriar commented Feb 25, 2019

Other terminals do this too.

@Tyriar Tyriar closed this as completed Feb 25, 2019
@Tyriar Tyriar added the invalid Issue identified as not relevant or not valid label Feb 25, 2019
@lxx2013
Copy link
Author

lxx2013 commented Feb 26, 2019

Well, Mac's default Terminal.app and iTerm2 won't do this. Disappointed at your reply.

@Tyriar
Copy link
Member

Tyriar commented Feb 26, 2019

Ah I wasn't reproducing the right thing, this appears to be specific behavior of Chinese IMEs. Repro:

  1. Enable PinYin IME
  2. Type (Chinese auto completions appear)
  3. Caps lock on
  4. Type - This should be lowercase in the terminal but it's uppercase

@Tyriar Tyriar reopened this Feb 26, 2019
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed invalid Issue identified as not relevant or not valid labels Feb 26, 2019
@henpin
Copy link

henpin commented Feb 27, 2019

i have same issue(Japanese IME
it appeared after updating latest MacOS

MacBook Pro (13-inch, 2017,
Mojave 10.14.3
code 1.31.1 (1.31.1)

@henpin
Copy link

henpin commented Feb 27, 2019

My problem is fixed

  1. Open keyboard settings -> input source
  2. set "CapsLock behavior" as "input Alphabet when CapsLock is Off"

2019-02-27 18 28 13

thx.

@Tyriar
Copy link
Member

Tyriar commented Mar 1, 2019

@lxx2013 did this comment help resolve the problem for you?

#68865 (comment)

@lxx2013
Copy link
Author

lxx2013 commented Mar 3, 2019

@lxx2013 did this comment help resolve the problem for you?

#68865 (comment)

I tried to set terminal.integrated.setLocaleVariables to true or false. It doesn't work.

My OSX version is 10.13.4. My Chinese IME is Baidu IME for Mac

@cyfyifanchen
Copy link

@henpin Brilliant

@cyfyifanchen
Copy link

Regarding #68865, @henpin's solution works fine for macOS's default Chinese input source ,but not for Sougou input, a 3rd party input source which is the most popular Chinese input.

@Tyriar
Copy link
Member

Tyriar commented Oct 8, 2019

Tracking upstream xtermjs/xterm.js#2457

@Tyriar Tyriar closed this as completed Oct 8, 2019
@yjw0628
Copy link

yjw0628 commented Nov 18, 2019

image

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants