Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling a theme still asks for reload in extension page #67466

Closed
octref opened this issue Jan 29, 2019 · 1 comment
Closed

Disabling a theme still asks for reload in extension page #67466

octref opened this issue Jan 29, 2019 · 1 comment
Assignees

Comments

@octref
Copy link
Contributor

octref commented Jan 29, 2019

Testing #67283

image

If we use dynamic enabling/disabling, we shouldn't show the "Reload" button and the text prompting user to reload.

@aeschli
Copy link
Contributor

aeschli commented Jan 30, 2019

The material theme is special as it also has code.

@aeschli aeschli closed this as completed Jan 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants