Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling the theme that contains the active theme does not change theme to default #67426

Closed
alexr00 opened this issue Jan 29, 2019 · 3 comments
Closed

Disabling the theme that contains the active theme does not change theme to default #67426

alexr00 opened this issue Jan 29, 2019 · 3 comments
Assignees
@aeschli
Labels
themes Color theme issues

Comments

@alexr00
Copy link
Member

alexr00 commented Jan 29, 2019

Found testing #67283.

Install Material Theme and apply a theme without reloading.
Theme is applied!
Disable Material Theme.
Reload is now required to revert to default theme.
@alexr00 alexr00 added the themes Color theme issues label Jan 29, 2019
@alexr00
Copy link
Member Author

alexr00 commented Jan 29, 2019

Same for icon theme.

@aeschli
Copy link
Contributor

aeschli commented Jan 31, 2019

@alexr00 Material Theme is special as it contains code as well and reload is required.
Do you see the same with other themes?

@alexr00
Copy link
Member Author

alexr00 commented Jan 31, 2019

Works for other themes!

@alexr00 alexr00 closed this as completed Jan 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
themes Color theme issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeschli @alexr00