Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input box: inherit font from workbench and do not set it #6171

Closed
bpasero opened this issue May 6, 2016 · 1 comment
Closed

Input box: inherit font from workbench and do not set it #6171

bpasero opened this issue May 6, 2016 · 1 comment
Assignees
Labels
debt Code quality issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented May 6, 2016

It looks like the input box is setting the font that is already defined in the workbench: https://github.com/Microsoft/vscode/blob/master/src/vs/base/browser/ui/inputbox/inputBox.css#L21

We should clean this up and have only one place where the font is defined (workbench) so that we a) do not have to repeat all the rules for other languages and b) make it easier to provide an option to configure the font used in VS Code.

@bpasero bpasero added the debt Code quality issues label May 6, 2016
@bpasero
Copy link
Member Author

bpasero commented May 6, 2016

@alexandrudima @jrieken not sure who to assign, I think this would have an impact on the find input and the rename box. I don't see other uses of input box in the editor afaik.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

3 participants