Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable dynamic menus on macOS in Insiders #58928

Closed
sbatten opened this issue Sep 19, 2018 · 3 comments · Fixed by #59855
Closed

Reenable dynamic menus on macOS in Insiders #58928

sbatten opened this issue Sep 19, 2018 · 3 comments · Fixed by #59855
Assignees
Labels
debt Code quality issues on-testplan
Milestone

Comments

@sbatten
Copy link
Member

sbatten commented Sep 19, 2018

As part of this, investigate the caching of menu items to quickly populate the menu on launch.

  • Cache items and restore a menu with everything enabled by default
  • When no window is open, use cached menu show disabled menu items
  • When item is triggered without render process, it will be scheduled.

/cc @bpasero

@sbatten sbatten added debt Code quality issues workbench-menu labels Sep 19, 2018
@sbatten sbatten self-assigned this Sep 19, 2018
@sbatten sbatten added this to the October 2018 milestone Sep 19, 2018
@sbatten
Copy link
Member Author

sbatten commented Oct 1, 2018

related: we can keep old application menus around to avoid GC as a workaround for #55347 to do this on linux as well

@bpasero
Copy link
Member

bpasero commented Oct 2, 2018

@sbatten I think we need the same trick on Windows as well (keep old menus around for a bit).

@bpasero
Copy link
Member

bpasero commented Oct 3, 2018

@sbatten just so that we do not forget, this needs a test plan item or verification needed at least. I will add the label now so we do not forget.

@bpasero bpasero added the verification-needed Verification of issue is requested label Oct 3, 2018
@sbatten sbatten added on-testplan and removed verification-needed Verification of issue is requested labels Oct 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants