Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a mechanism to set a menu entry to "checked" #58422

Closed
bpasero opened this issue Sep 11, 2018 · 1 comment · Fixed by #60004
Closed

Provide a mechanism to set a menu entry to "checked" #58422

bpasero opened this issue Sep 11, 2018 · 1 comment · Fixed by #60004
Assignees
@sbatten
Labels
debt Code quality issues
Milestone
On Deck

Comments

@bpasero
Copy link
Member

bpasero commented Sep 11, 2018

It looks like this is a hack only for one menu item: https://github.com/Microsoft/vscode/blob/677b68da48fb4e1f518801fd06fba2200fdc6e41/src/vs/workbench/browser/parts/titlebar/menubarControl.ts#L491

There should be a general solution to set a menu entry to be checked or not. This enables: #46807 and #14986
@bpasero bpasero added debt Code quality issues workbench-menu labels Sep 11, 2018
@sbatten sbatten added this to the On Deck milestone Sep 11, 2018
@eamodio
Copy link
Contributor

eamodio commented Sep 20, 2018

It would be wonderful if extensions could get in on this too!

@sbatten sbatten mentioned this issue Oct 5, 2018
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
debt Code quality issues
Projects
None yet
Milestone
On Deck
Development

Successfully merging a pull request may close this issue.

adding ability to set checked state for menu item at registration sbatten/vscode
3 participants
@eamodio @bpasero @sbatten