Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test feasibility of entering offline mode #55408

Closed
1 task done
ramya-rao-a opened this issue Jul 31, 2018 · 3 comments
Closed
1 task done

Test feasibility of entering offline mode #55408

ramya-rao-a opened this issue Jul 31, 2018 · 3 comments

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jul 31, 2018

Testing #54354

Complexity: 2

  • Go through Offline mode for VS Code #54354 (comment) and see if we missed any documenting any feature of VS Code that would make a network request.
  • Test the new settings extensions.autoCheckUpdates, npm.fetchOnlinePackageInfo.
  • Ensure the Show settings for Online Services in the new settings editor displays all the settings related to features that make network requests.

Also see #55374 for ongoing discussion around the Show settings for Online Services view for more info

@chrmarti
Copy link
Collaborator

@ramya-rao-a A few more:

  • Icon and badges in the extension editor are loaded from remote IIRC.
  • Similarly the markdown previewer can load images from remote.
  • The Experiments service.

@chrmarti chrmarti removed their assignment Jul 31, 2018
@chrmarti
Copy link
Collaborator

Also: Issue reporter does a duplicate search.

@ramya-rao-a
Copy link
Contributor Author

Thanks @chrmarti, I've updated #54354 accordingly and will include the above in the documentation.
Will add a setting for experiments. Rest are followups from a user invoked action, so they dont need a setting.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants