Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Support PCRE regex for extension? #50872

Closed
Geobert opened this issue May 31, 2018 · 6 comments
Closed

[Question] Support PCRE regex for extension? #50872

Geobert opened this issue May 31, 2018 · 6 comments
Labels
*out-of-scope Posted issue is not in scope of VS Code

Comments

@Geobert
Copy link

Geobert commented May 31, 2018

I don't know if it's the correct place to ask question on VSCode so bear with me if I'm mistaken :)

Is there any plan to support PCRE regex in the future?

Or at least ECMA 2018 regex to have lookbehind ((?<=) and (?<!)) support

Thanks

@vscodebot
Copy link

vscodebot bot commented May 31, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@octref
Copy link
Contributor

octref commented May 31, 2018

You should open issue for https://github.com/Microsoft/TypeScript for ECMA 2018 regex support.

@octref octref closed this as completed May 31, 2018
@octref octref added the *out-of-scope Posted issue is not in scope of VS Code label May 31, 2018
@Geobert
Copy link
Author

Geobert commented May 31, 2018

Done microsoft/TypeScript#24531

@mhegazy
Copy link

mhegazy commented Jun 1, 2018

Based on the discussion in microsoft/TypeScript#24531, I believe the request here is to allow using ES2018 features in the regexp's support in VSCode features like find/replace. TypeScript is driving the language service for TS and JS but has nothing to do with executing/evaluating these regexp's in VSCode.

@Geobert
Copy link
Author

Geobert commented Jun 4, 2018

@octref: Should this be reopened?

@octref
Copy link
Contributor

octref commented Jun 4, 2018

We use ripgrep and seems no: BurntSushi/ripgrep#188

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants