Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode sends search keystrokes to Microsoft even with telemetry disabled #49161

Closed
taoeffect opened this issue May 4, 2018 · 10 comments
Closed
Assignees
Labels
search Search widget and operation issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@taoeffect
Copy link

taoeffect commented May 4, 2018

  • VSCode Version: Insider build on May 3, 2018
  • OS Version: macOS

Steps to Reproduce:

  1. Download latest insider build
  2. Run
  3. Disable telemetry settings and restart VSCode
  4. Open a file (or in my case, the settings), and do Command+F to search, and search for something

Does this issue occur when all extensions are disabled?: didn't try


VSCode will attempt to connect to Bing as you search:

screen shot 2018-05-03 at 8 00 30 pm

@vscodebot vscodebot bot added the search Search widget and operation issues label May 4, 2018
@dd86k
Copy link

dd86k commented May 4, 2018

If this can't even be disabled as an internal extension, which I doubt it is, then it's a major issue. No surprise by the confusion made at the the beginning of the VS Code product (not project) regarding licensing (which you mentioned in your toot).

VS Code is my Tool of the Trade, but unfortunately if I have to fork and let aside my current projets, I won't get any happier.

@DickvdBrink
Copy link
Contributor

DickvdBrink commented May 4, 2018

Lol, probably just an oversight because they made the search a lot better
(https://code.visualstudio.com/blogs/2018/04/25/bing-settings-search).

So I think it only does this on the settings file and not on other files ;)

@darshanrampatel
Copy link

Duplicate of #44294

@roblourens
Copy link
Member

Yes, it can be disabled with "workbench.settings.enableNaturalLanguageSearch": false

@marmistrz
Copy link

This should definitely be an opt-in!

@levrik
Copy link

levrik commented May 4, 2018

@roblourens I agree with @marmistrz. Maybe show an notification the first time a user opens the settings page to ask if they want to activate this. It should make clear that with that enabled data is sent to Microsoft servers.

@roblourens roblourens added the under-discussion Issue is under discussion for relevance, priority, approach label May 4, 2018
@roblourens
Copy link
Member

We've tried to address this and other similar issues by making it easier to find settings that control features that involve online features. You can use the ... menu in the settings UI to find the "Show settings for online services" menu, which will filter the settings list to just those settings.

image

There was some discussion of this here #54354

@sneq0
Copy link

sneq0 commented Sep 13, 2018

Awful, removing it asap. I don't want someone to spy on me in IDE.

@roblourens
Copy link
Member

To reiterate,

it can be disabled with "workbench.settings.enableNaturalLanguageSearch": false

@marmistrz
Copy link

How about adding some notification, banner, etc. that such settings exist, and unless changed, data may be sent to Microsoft servers?

That's exactly what Mozilla Firefox does, see its first-run behavior for clarification

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
search Search widget and operation issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

8 participants