Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompletionList should be able to point to best suggestion #47102

Closed
ghost opened this issue Apr 2, 2018 · 5 comments
Closed

CompletionList should be able to point to best suggestion #47102

ghost opened this issue Apr 2, 2018 · 5 comments
Assignees
Labels
api feature-request Request for new features or functionality suggest IntelliSense, Auto Complete

Comments

@ghost
Copy link

ghost commented Apr 2, 2018

Issue Type: Bug

(Recommended completions were added in microsoft/TypeScript#20020.)
Test with:

enum E { A, B }
const e: E = 

Hit ctrl-space to get completions after the =. E will be put at the top of the completions list instead of sorted by name. The problem is, the completion list is immediately focused on console, leaving E offscreen where it will probably never be seen. It would be better to immediately focus on E, and leave it sorted by alphabetically.

VS Code version: Code - Insiders 1.22.0-insider (6c22e21, 2018-03-30T14:36:39.526Z)
OS version: Linux x64 4.13.0-37-generic

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2600)
Load (avg) 1, 1, 1
Memory (System) 7.63GB (1.66GB free)
Process Argv /usr/share/code-insiders/code-insiders src
Screen Reader no
VM 0%
Extensions: none
@vscodebot vscodebot bot added the insiders label Apr 2, 2018
@jrieken
Copy link
Member

jrieken commented Apr 3, 2018

use "editor.suggestSelection": "first",

@jrieken jrieken added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Apr 3, 2018
@vscodebot
Copy link

vscodebot bot commented Apr 3, 2018

Please ask your question on StackOverflow. We have a great community over there. They have already answered thousands of questions and are happy to answer yours as well. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Apr 3, 2018
@ghost
Copy link
Author

ghost commented Apr 6, 2018

@mjbvz Could you reopen this? Based on our discussion yesterday, the editor should prioritize the currently recommended completion over reusing a previous completion.

@mjbvz mjbvz reopened this Apr 6, 2018
@mjbvz mjbvz removed the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Apr 6, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 6, 2018

@jrieken We'd like a way for extensions to flag a suggestion as recommended so that it takes priority over the suggestion history

@mjbvz mjbvz added api suggest IntelliSense, Auto Complete typescript Typescript support issues javascript JavaScript support issues labels Apr 6, 2018
@jrieken jrieken removed javascript JavaScript support issues typescript Typescript support issues labels Apr 9, 2018
@jrieken jrieken changed the title Recommended completion is ignored in favor of 'console' CompletionList should be able to point to best suggestion Apr 9, 2018
@jrieken jrieken added the feature-request Request for new features or functionality label Apr 9, 2018
@jrieken
Copy link
Member

jrieken commented Sep 10, 2018

@jrieken jrieken closed this as completed Sep 10, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality suggest IntelliSense, Auto Complete
Projects
None yet
Development

No branches or pull requests

2 participants