Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Auto attach for Node-Debug #46570

Closed
3 tasks done
weinand opened this issue Mar 26, 2018 · 1 comment
Closed
3 tasks done

Test: Auto attach for Node-Debug #46570

weinand opened this issue Mar 26, 2018 · 1 comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Mar 26, 2018

Test for #42521:

Complexity: 2

In this milestone we've added an "Auto Attach" feature to VS Code's Node.js debugger. If enabled the node debugger (both protocols) automatically attaches to node.js processes that are launched in debug mode in VS Code's integrated terminal.

To enable the feature either use the "Toggle Auto Attach" action or if the Node Debug is already activated use the "Auto Attach" status bar item.

2018-03-27_21-24-54

Whether a process is in debug mode is guessed by analysing the program arguments. Currently we detect the patterns --inspect, --inspect-brk, --inspect-port, --debug, --debug-brk, --debug-port (all optionally followed by a '=' and a port number).

Please note that this feature does not yet work for terminal multiplexers (where launched processes are not children of VS Code's integrated terminal.

Test:

  • verify that the feature is turned off initially
  • enable the feature
  • verify that the node debugger attaches to node.js programs if they are launched with the various debug flags from above ("inspect" for node.js >= 6.3, "debug" for node.js < 8.0).
  • verify that disabling the feature stops the auto-attach behavior

On Windows watch out for too many or stuck 'wmic' processes that cripple performance.

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item labels Mar 26, 2018
@weinand weinand added this to the March 2018 milestone Mar 26, 2018
@weinand weinand self-assigned this Mar 26, 2018
@weinand weinand changed the title Test: Auto attach Test: Auto attach for Node-Debug Mar 26, 2018
@weinand weinand removed their assignment Mar 26, 2018
@chrmarti chrmarti removed their assignment Mar 27, 2018
@aeschli aeschli removed their assignment Mar 27, 2018
@rebornix rebornix assigned sbatten and unassigned rebornix Mar 27, 2018
@weinand
Copy link
Contributor Author

weinand commented Mar 28, 2018

Checking off for @sbatten since he did testing (despite the fact that he found an fundamental issue).

@weinand weinand closed this as completed Mar 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

5 participants