VS Code Insiders installs always in the OS language despite of language selection during installation

[carlosmunozrodriguez]

• VSCode Version: 0.10.12-insider
• OS Version: Windows 10

Steps to Reproduce:

1. Download VS Code Insiders from https://code.visualstudio.com/insiders
2. Install using a different language than the OS. (Tested with selecting English and with a Windows 10 in Spanish)
3. Open VS Code Insiders. It will be on your OS language instead of the one you selected.

[dbaeumer]

The language selection dialog is currently only for the Setup wizard. The question is whether we should create a locale.json file based on this information. I opt to do so.

@chrisdias, @egamma what is your opinion
@joaomoreno would that be possible from the InnoSetup installer.

[joaomoreno]

I suggest to set up Inno to automatically detect the language at installation time, just like what Code does. The picker would only show up in ambiguous cases and it only has an effect in the setup itself.

[dbaeumer]

+1

I assign to you then.

[joaomoreno]

Closing as we track this in another repo.

[carlosmunozrodriguez]

Can I ask which repo?
Also a question: How will it detect the language? Which language? I have also installed regular English VS Code in a Spanish OS

[joaomoreno]

@carlosmunozrodriguez We have another repository in which we track the things that ultimately make VS Code into an MS branded product. This is one of those things. More information about this here.

There are helpful links about understanding how language detection will happen:

• Languages
• LanguageDetectionMethod
• ShowLanguageDialog